linux-kernel - Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251221-platinum-mongoose-of-might-feec86@quoll>
Date: Sun, 21 Dec 2025 16:05:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, pavel@...nel.org, sakari.ailus@...ux.intel.com, 
	mehdi.djait@...ux.intel.com, laurent.pinchart@...asonboard.com, hverkuil+cisco@...nel.org, 
	linux-media@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert
 to DT schema

On Sat, Dec 20, 2025 at 02:03:24PM -0800, Alex Tran wrote:
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
> new file mode 100644
> index 000000000000..68a8134df8fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/toshiba,et8ek8.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Toshiba et8ek8 5MP sensor
> +
> +maintainers:
> +  - Pavel Machek <pavel@....cz>
> +  - Sakari Ailus <sakari.ailus@....fi>
> +
> +description:
> +  Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> +
> +properties:
> +  compatible:
> +    const: toshiba,et8ek8
> +
> +  reg:
> +    description:
> +      I2C address (0x3e, or an alternative address)
> +    maxItems: 1
> +
> +  vana-supply:
> +    description:
> +      Analogue voltage supply (VANA), 2.8 volts
> +
> +  clocks:
> +    description:
> +      External clock to the sensor

If there is going to be new version: drop description, obvious.

> +    maxItems: 1
> +
> +  reset-gpios:
> +    description:
> +      XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
> +      is in hardware standby mode when the signal is in the low state.
> +    maxItems: 1
> +
> +  flash-leds:
> +    $ref: /schemas/media/video-interfaces.yaml#

This and...

> +
> +  lens-focus:
> +    $ref: /schemas/media/video-interfaces.yaml#

... this are weird. LEDs are not video interfaces, for sure. lens focus
shouldn't be video interface, either.

You also miss unevaluatedProps there.

This needs careful fixing/rewriting, with explanation in commit msg.


> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          remote-endpoint: true

Drop, pointless.


> +
> +required:
> +  - compatible
> +  - reg
> +  - vana-supply
> +  - clocks
> +  - reset-gpios
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camera@3e {
> +            compatible = "toshiba,et8ek8";
> +            reg = <0x3e>;
> +            vana-supply = <&vaux4>;
> +            clocks = <&isp 0>;
> +            assigned-clocks = <&isp 0>;
> +            assigned-clock-rates = <9600000>;
> +            reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> +
> +            port {
> +                csi_cam1: endpoint {
> +                    remote-endpoint = <&csi_out1>;
> +                };

Please make the example complete - missing flash-leds and lens-focus. If
you provided them, you would see your binding is not correct.


Best regards,
Krzysztof