linux-kernel - Re: [PATCH v12 2/2] iio: magnetometer: Add mmc5633 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251221190742.4162108b@jic23-huawei>
Date: Sun, 21 Dec 2025 19:07:42 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: Frank Li <Frank.Li@....com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Miquel Raynal <miquel.raynal@...tlin.com>,
 David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
 linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-iio@...r.kernel.org,
 joshua.yeong@...rfivetech.com, devicetree@...r.kernel.org,
 linux@...ck-us.net, Carlos Song <carlos.song@....com>, Adrian Fluturel
 <fluturel.adrian@...il.com>
Subject: Re: [PATCH v12 2/2] iio: magnetometer: Add mmc5633 sensor

On Sat, 20 Dec 2025 22:34:47 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Frank,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on 8f0b4cce4481fb22653697cced8d0d04027cb1e8]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/dt-bindings-trivial-devices-add-MEMSIC-3-axis-magnetometer/20251216-010451
> base:   8f0b4cce4481fb22653697cced8d0d04027cb1e8
> patch link:    https://lore.kernel.org/r/20251215-i3c_ddr-v12-2-1ae31225b4d9%40nxp.com
> patch subject: [PATCH v12 2/2] iio: magnetometer: Add mmc5633 sensor
> config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20251220/202512202141.aAwyC19D-lkp@intel.com/config)
> compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251220/202512202141.aAwyC19D-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202512202141.aAwyC19D-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/iio/magnetometer/mmc5633.c:362:2: error: cannot jump from switch statement to this case label  
>      362 |         default:
>          |         ^
>    drivers/iio/magnetometer/mmc5633.c:357:3: note: jump bypasses initialization of variable with __attribute__((cleanup))
>      357 |                 guard(mutex)(&data->mutex);
>          |                 ^
>    include/linux/cleanup.h:414:15: note: expanded from macro 'guard'
>      414 |         CLASS(_name, __UNIQUE_ID(guard))
>          |                      ^
>    include/linux/compiler.h:168:2: note: expanded from macro '__UNIQUE_ID'
>      168 |         __PASTE(__UNIQUE_ID_,                                   \
>          |         ^
>    include/linux/compiler_types.h:16:23: note: expanded from macro '__PASTE'
>       16 | #define __PASTE(a, b) ___PASTE(a, b)
>          |                       ^
>    include/linux/compiler_types.h:15:24: note: expanded from macro '___PASTE'
>       15 | #define ___PASTE(a, b) a##b
>          |                        ^
>    <scratch space>:9:1: note: expanded from here
>        9 | __UNIQUE_ID_guard_966
>          | ^
>    1 error generated.
> 
> 
> vim +362 drivers/iio/magnetometer/mmc5633.c
> 
>    343	
>    344	static int mmc5633_write_raw(struct iio_dev *indio_dev,
>    345				     struct iio_chan_spec const *chan, int val,
>    346				     int val2, long mask)
>    347	{
>    348		struct mmc5633_data *data = iio_priv(indio_dev);
>    349		int ret;
>    350	
>    351		switch (mask) {
>    352		case IIO_CHAN_INFO_SAMP_FREQ:
{
>    353			ret = mmc5633_get_samp_freq_index(data, val, val2);
>    354			if (ret < 0)
>    355				return ret;
>    356	
>    357			guard(mutex)(&data->mutex);
>    358	
>    359			return regmap_update_bits(data->regmap, MMC5633_REG_CTRL1,
>    360						  MMC5633_CTRL1_BW_MASK,
>    361						  FIELD_PREP(MMC5633_CTRL1_BW_MASK, ret));
}
Needed to add scope for the guard to apply to.
If this is all that comes up I'll fix it whilst applying.

thanks,

Jonathan

>  > 362		default:  
>    363			return -EINVAL;
>    364		}
>    365	}
>    366	
>