linux-kernel - Re: [PATCH] KVM: selftests: Fix sign extension bug in get_desc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c70edd09-f8fe-4266-abc6-5911c13c9159@pooladkhay.com>
Date: Mon, 22 Dec 2025 17:27:10 +0000
From: MJ Pooladkhay <mj@...ladkhay.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: pbonzini@...hat.com, shuah@...nel.org, kvm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: selftests: Fix sign extension bug in
 get_desc64_base()

On Mon, Dec 22, 2025, Sean Christopherson wrote:

> Ugh, I hate integer promotion rules.  I wish there was a more useful version of
> -Wconversion :-/
True! It caused me weeks of grief tracking down these triple faults!
> I don't see any reason to have an intermediate "low", it just makes it harder
> to piece the entire thing together.  My vote is for:
>
> 	return (uint64_t)desc->base3 << 32 |
> 	       (uint64_t)desc->base2 << 24 |
> 	       (uint64_t)desc->base1 << 16 |
> 	       (uint64_t)desc->base0;

Thanks for the review. I agree, your version is much cleaner. I will 
send a v2 with this change shortly.

Best,
MJ Pooladkhay