linux-kernel - Re: [PATCH v4 00/12] media: Add support for R-Car ISP using Dreamchip RPPX1 ISP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de5e22b9-5a35-47b4-b290-06729b56c887@mailbox.org>
Date: Mon, 22 Dec 2025 11:52:42 +0100
From: Marek Vasut <marek.vasut@...lbox.org>
To: Niklas Söderlund
 <niklas.soderlund+renesas@...natech.se>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 00/12] media: Add support for R-Car ISP using Dreamchip
 RPPX1 ISP

On 11/11/25 10:02 AM, Niklas SÃ¶derlund wrote:
> Hello,
> 
> This series adds support for two different devices that together enable
> ISP support on Renesas R-Car Gen4 ISP processing. The first driver added
> is for Dreamchip RPPX1 ISP, this device purely deals with image
> processing algorithms, statistics and image conversion; but have no DMA
> engines. The second driver is for the R-Car ISP CORE, this device
> deals with DMA to/from the RPPX1 ISP and provides a V4L2 user-space
> interface for the ISP.
> 
> The R-Car ISP driver uses the RPPX1 framework to drive the ISP and
> together the two devices provide a functional ISP. For detailed
> description of the RPPX1 see patch 1/12, and for details about the R-Car
> ISP see commit message in patch 2/12.
> 
> The RPPX1 ISP is similar to functionality and design to the Rk1ISP
> already supported upstream. For this reason this series reuses the pixel
> format for ISP parameters (RK1E) and statistics (RK1S) as the user-space
> ABI to configure the ISP. The primary difference to Rk1iSP is the over
> all pipeline design and the register layout out is different enough to
> make it impractical to bolt it on the existing drivers.
> 
> However on a functional block level the blocks amiable and their
> register layout mapped to the buffer formats are similar enough to make
> the reuse practical. Another difference is that RPPX1 operates at a
> hight bitdepth then Rk1ISP, but this is easily supported by scaling the
> values to/from the buffers.
> 
> All functional blocks present on the RPPX1 are not yet added to the
> driver, but most are. Hence not all configuration blocks of the Rk1E
> extensible format are supported, but most if not all can be added.
> 
> A libcamera pipeline reusing the Rk1ISP IPA have been posted and it can
> exercise all function block enabled by this series. It produce good
> images using all algorithms available.
> 
> Patch 1/12 adds the foundation for the RPPX1 framework. It deals with
> probing all function blocks making sure every blocks version register is
> supported and setup a "passthru" pipeline that just debayer RAW images.
> 
> Patch 2/12 integrates the adds the R-Car ISP CORE DMA parts and
> integrates with the RPPX1 framework added in patch 1/12.
> 
> Patches 3/12 to 12/12 extends the RPPX1 framework with the logic to drive
> the different IPS modules.
> 
> The sum of the work pass v4l2-compliance. A test suite for the enabled
> function blocks exists and pass. The work have also been tested with
> various libcamera utilities and compliance tests together with a IMX219
> and IMX462 sensor on R-Car V4H.
> 
> Biggest change from v3 is small fixes that 0day found when building for
> non ARM architectures.

For this series, please add my:

Tested-by: Marek Vasut'<marek.vasut+renesas@...lbox.org>

# On Retronix Sparrow Hawk with Renesas R-Car R8A779G3 rev. 3.1 SoC .

Thank you !