[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d00b500e-31e9-4951-852f-c612a5d779a0@ideasonboard.com>
Date: Mon, 22 Dec 2025 12:55:47 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>, mchehab@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
hverkuil@...all.nl, sakari.ailus@...ux.intel.com,
laurent.pinchart@...asonboard.com
Cc: hansg@...nel.org, mehdi.djait@...ux.intel.com, ribalda@...omium.org,
git@...tzsch.eu, vladimir.zapolskiy@...aro.org,
benjamin.mugnier@...s.st.com, dongcheng.yan@...el.com, u-kumar1@...com,
jai.luthra@...ux.dev, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 1/4] media: dt-bindings: ti,ds90ub960: Refactor port
definitions
Hi,
On 19/12/2025 14:29, Yemike Abhilash Chandra wrote:
> The current bindings duplicate the port definitions for each FPD-Link RX
> and CSI-2 TX ports. This results in a large amount of repeated schema
> blocks and makes it harder to extend the bindings for new devices.
>
> Refactor the bindings by introducing shared deftinitions for FPD-Link
> input ports and CSI-2 output ports. No functional change intended.
>
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@...com>
> ---
> Changelog:
> Changes in v3:
> - Remove the | character from the ports description since preserving formatting is not required. (Rob)
> - Wrap the ports description at 80 characters. (Rob)
>
> .../bindings/media/i2c/ti,ds90ub960.yaml | 120 +++++++-----------
> 1 file changed, 44 insertions(+), 76 deletions(-)
My DT skills are not good enough to say if this is 100% correct or not,
but it makes sense and looks good to me. So:
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Tomi
Powered by blists - more mailing lists