linux-kernel - Re: [PATCH v3 01/13] rv: Unify DA event handling functions across monitor types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c86695dc26202d2cfafdb636d32c47a8c3d6b15.camel@redhat.com>
Date: Mon, 22 Dec 2025 15:45:36 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Nam Cao <namcao@...utronix.de>, linux-kernel@...r.kernel.org, Steven
 Rostedt <rostedt@...dmis.org>, linux-trace-kernel@...r.kernel.org
Cc: Tomas Glozar <tglozar@...hat.com>, Juri Lelli <jlelli@...hat.com>, Clark
 Williams <williams@...hat.com>, John Kacur <jkacur@...hat.com>
Subject: Re: [PATCH v3 01/13] rv: Unify DA event handling functions across
 monitor types

On Thu, 2025-12-18 at 08:04 +0700, Nam Cao wrote:
> I think this overexplains. I would just explain the "WHY", then the
> general idea how the patch solves the problem. Let the diff speaks for
> the rest.
> 
> Perhaps something like:
> 
>     The DA event handling functions are mostly duplicated for
>     differerent monitor types, because per-task monitors' functions
>     require a task_struct parameter while the others do not.
> 
>     Unify the functions, handle the difference by always passing a
>     da_id_type which is the task's pid for per-task monitor but is
>     ignored for the other types.
> 

Good point, I'll squeeze it.
Thanks,
Gabriele

> Regardless:
> 
> Reviewed-by: Nam Cao <namcao@...utronix.de>
> 
> Nam