linux-kernel - Re: [PATCH 3/6] i2c: amd-asf-plat: use i2c_adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ec59326-fb63-4236-9c10-3ee37763129b@amd.com>
Date: Tue, 23 Dec 2025 16:51:23 +0530
From: Shyam Sundar S K <Shyam-sundar.S-k@....com>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Jean Delvare <jdelvare@...e.com>, Andi Shyti <andi.shyti@...nel.org>,
 Nirujogi Pratap <pratap.nirujogi@....com>, Bin Du <bin.du@....com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Gregory CLEMENT
 <gregory.clement@...tlin.com>, Hans Hu <hanshu@...oxin.com>
Cc: Bartosz Golaszewski <brgl@...nel.org>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] i2c: amd-asf-plat: use i2c_adapter_dev()



On 12/23/2025 15:38, Bartosz Golaszewski wrote:
> Use i2c_adapter_dev() where applicable in order to avoid direct
> dereferencing of struct device embedded within struct i2c_adapter.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>

Thanks,
Shyam

> ---
>  drivers/i2c/busses/i2c-amd-asf-plat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c
> index ca45f0f233210a3b03a16c4a240012bd524fefb0..271b1b24417d06cc87733268c3191aea16fa1d83 100644
> --- a/drivers/i2c/busses/i2c-amd-asf-plat.c
> +++ b/drivers/i2c/busses/i2c-amd-asf-plat.c
> @@ -209,7 +209,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>  	asf_data[0] = dev_msgs->len;
>  	memcpy(asf_data + 1, dev_msgs[0].buf, dev_msgs->len);
>  
> -	ret = piix4_sb800_region_request(&adap->dev, &dev->mmio_cfg);
> +	ret = piix4_sb800_region_request(i2c_adapter_dev(adap), &dev->mmio_cfg);
>  	if (ret)
>  		return ret;
>  
> @@ -224,7 +224,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>  	ret = amd_asf_access(adap, msgs->addr, msgs[0].buf[0], asf_data);
>  	piix4_sb800_port_sel(prev_port, &dev->mmio_cfg);
>  	amd_asf_setup_target(dev);
> -	piix4_sb800_region_release(&adap->dev, &dev->mmio_cfg);
> +	piix4_sb800_region_release(i2c_adapter_dev(adap), &dev->mmio_cfg);
>  	return ret;
>  }
>  
>