[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2eec4b3c0fff4869c599558a7e851d052eb60e0e.camel@mediatek.com>
Date: Wed, 24 Dec 2025 06:13:05 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "chu.stanley@...il.com" <chu.stanley@...il.com>, "robh@...nel.org"
<robh@...nel.org>, Chunfeng Yun (云春峰)
<Chunfeng.Yun@...iatek.com>, "kishon@...nel.org" <kishon@...nel.org>,
"James.Bottomley@...senpartnership.com"
<James.Bottomley@...senpartnership.com>, "bvanassche@....org"
<bvanassche@....org>, AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Chaotian Jing (井朝天)
<Chaotian.Jing@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"nicolas.frattaroli@...labora.com" <nicolas.frattaroli@...labora.com>,
"vkoul@...nel.org" <vkoul@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "avri.altman@....com"
<avri.altman@....com>, "broonie@...nel.org" <broonie@...nel.org>,
"martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-phy@...ts.infradead.org"
<linux-phy@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>, Louis-Alexis Eyraud
<louisalexis.eyraud@...labora.com>, "kernel@...labora.com"
<kernel@...labora.com>
Subject: Re: [PATCH v4 07/25] scsi: ufs: mediatek: Rework 0.9V regulator
On Tue, 2025-12-23 at 17:13 +0100, Nicolas Frattaroli wrote:
>
>
> Hi,
>
> that would allow compatibles that are not allowed to have an avdd09
> regulator by the binding (because the SoC doesn't have that pin) to
> have one specified in the device tree get picked up. This would then
> cause those devices with such a device tree to enter
> ufs_mtk_va09_pwr_ctrl(), which is not what we want. While we could
> blame this on the DT being wrong in that case, I think it's better
> if we avoid such a situation entirely.
>
> Kind regards,
> Nicolas Frattaroli
>
>
Hi Nicolas,
Okay, this does help avoid issues caused by incorrect DTS
settings. Although it increases the complexity of the code,
it provides a mistake proofing.
Thanks.
Reviewed-by: Peter Wang <peter.wang@...iatek.com>
Powered by blists - more mailing lists