linux-kernel - Re: [PATCH v4 08/25] scsi: ufs: mediatek: Rework init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb912a89b651bd64a0f2f088bd4f802b68825d80.camel@mediatek.com>
Date: Wed, 24 Dec 2025 06:14:19 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "chu.stanley@...il.com" <chu.stanley@...il.com>, "robh@...nel.org"
	<robh@...nel.org>, Chunfeng Yun (云春峰)
	<Chunfeng.Yun@...iatek.com>, "kishon@...nel.org" <kishon@...nel.org>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "bvanassche@....org"
	<bvanassche@....org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "neil.armstrong@...aro.org"
	<neil.armstrong@...aro.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	Chaotian Jing (井朝天)
	<Chaotian.Jing@...iatek.com>, "lgirdwood@...il.com" <lgirdwood@...il.com>,
	"nicolas.frattaroli@...labora.com" <nicolas.frattaroli@...labora.com>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "avri.altman@....com" <avri.altman@....com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"broonie@...nel.org" <broonie@...nel.org>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, Louis-Alexis Eyraud
	<louisalexis.eyraud@...labora.com>, "kernel@...labora.com"
	<kernel@...labora.com>
Subject: Re: [PATCH v4 08/25] scsi: ufs: mediatek: Rework init function

On Thu, 2025-12-18 at 13:54 +0100, Nicolas Frattaroli wrote:
> Printing an error message on ENOMEM is pointless. The print will not
> work because there is no memory.
> 
> Adding an of_match_device to the init function is pointless. Why
> would a
> different device with a different probe function ever use the same
> init
> function? Get rid of it.
> 
> zero-initialising an error variable just so you can then goto a bare
> return statement with that error variable to signal success is also
> pointless, just return directly, there's no unwind being done.
> 
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>

Reviewed-by: Peter Wang <peter.wang@...iatek.com>