linux-kernel - Re: [PATCH v3 6/7] dt-bindings: pinctrl: rockchip: Add RMIO controller binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f58ccc03-286e-4ca0-acc4-6c6474a9df5c@kernel.org>
Date: Thu, 25 Dec 2025 09:36:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ye Zhang <ye.zhang@...k-chips.com>,
 Linus Walleij <linus.walleij@...aro.org>, Heiko Stuebner <heiko@...ech.de>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 tao.huang@...k-chips.com
Subject: Re: [PATCH v3 6/7] dt-bindings: pinctrl: rockchip: Add RMIO
 controller binding

On 25/12/2025 04:25, Ye Zhang wrote:
>>> +/* RMIO function definition */
>>> +#define RMIO_UART1_TX			1
>>> +#define RMIO_UART1_RX			2
>>> +#define RMIO_UART2_TX			3
>>> +#define RMIO_UART2_RX			4
>>> +#define RMIO_UART3_TX			5
>>> +#define RMIO_UART3_RX			6
>>> +#define RMIO_UART3_CTSN			7
>>> +#define RMIO_UART3_RTSN			8
>>> +#define RMIO_UART4_TX			9
>>> +#define RMIO_UART4_RX			10
>>> +#define RMIO_UART4_CTSN			11
>>> +#define RMIO_UART4_RTSN			12
>>> +#define RMIO_MIPITE			13
>>> +#define RMIO_CLK_32K			14
>>> +#define RMIO_I2C0_SCL			15
>>> +#define RMIO_I2C0_SDA			16
>>
>> I do not see how this is a binding. Please point me to the patch using
>> this in the driver.
> These macros are intended to be used in the Device Tree sources to 
> improve readability, avoiding “magic numbers” for the RMIO function IDs.

That was not my question. Read again what I asked.

So not a binding, remove.


Best regards,
Krzysztof