linux-kernel - Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e8ec6ac-91e2-411c-8ca5-562b48443be6@kernel.org>
Date: Thu, 25 Dec 2025 09:37:16 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, pavel@...nel.org, sakari.ailus@...ux.intel.com,
 mehdi.djait@...ux.intel.com, laurent.pinchart@...asonboard.com,
 hverkuil+cisco@...nel.org, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert
 to DT schema

On 24/12/2025 22:07, Alex Tran wrote:
>>> +    maxItems: 1
>>> +
>>> +  reset-gpios:
>>> +    description:
>>> +      XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
>>> +      is in hardware standby mode when the signal is in the low state.
>>> +    maxItems: 1
>>> +
>>> +  flash-leds:
>>> +    $ref: /schemas/media/video-interfaces.yaml#
>>
>> This and...
>>
>>> +
>>> +  lens-focus:
>>> +    $ref: /schemas/media/video-interfaces.yaml#
>>
>> ... this are weird. LEDs are not video interfaces, for sure. lens focus
>> shouldn't be video interface, either.
>>
>> You also miss unevaluatedProps there.
>>
>> This needs careful fixing/rewriting, with explanation in commit msg.
>>
> 
> My mistake. The correct schema reference for these 2 should be video
> interface devices.

No. LEDs are not video interface devices, either. LEDs are LEDs.

Best regards,
Krzysztof