linux-kernel - Re: [PATCH v2 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ec9a2f6a-4cad-4989-8d40-af7b718a164b@kernel.org>
Date: Thu, 25 Dec 2025 10:08:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Pavel Machek <pavel@....cz>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert
 to DT schema

On 25/12/2025 09:57, Alex Tran wrote:
> On Thu, Dec 25, 2025 at 12:40 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 24/12/2025 22:59, Alex Tran wrote:
>>> +
>>> +  reset-gpios:
>>> +    description:
>>> +      XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
>>> +      is in hardware standby mode when the signal is in the low state.
>>> +    maxItems: 1
>>> +
>>> +  flash-leds: true
>>> +  lens-focus: true
>>
>> No, where did you find this syntax. I do not see how you carefully fixed
>> it. You need proper schema for these.
>>
>> Best regards,
>> Krzysztof
> 
> I saw it used under sony,imx214.yaml and mipi-ccs.yaml. I thought referencing
> video-interface-devices.yaml in this schema was correct because the flash-leds
> and lens-focus properties are both specified in that file.

Ah, so you wanted to reference video-inteface-devices in top-level?
Wasn't this already before? If that was missing then that's another
thing to fix.

And then you need to use unevaluatedProperties: false. flash-leds needs
constraints, number of items. lens-focus you simply remove.

Best regards,
Krzysztof