linux-kernel - Re: [PATCH v2 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251227111206.GF4094@pendragon.ideasonboard.com>
Date: Sat, 27 Dec 2025 13:12:06 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Alex Tran <alex.t.tran@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Pavel Machek <pavel@....cz>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert
 to DT schema

Hi Krzysztof,

On Thu, Dec 25, 2025 at 10:08:47AM +0100, Krzysztof Kozlowski wrote:
> On 25/12/2025 09:57, Alex Tran wrote:
> > On Thu, Dec 25, 2025 at 12:40 AM Krzysztof Kozlowski wrote:
> >> On 24/12/2025 22:59, Alex Tran wrote:
> >>> +
> >>> +  reset-gpios:
> >>> +    description:
> >>> +      XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
> >>> +      is in hardware standby mode when the signal is in the low state.
> >>> +    maxItems: 1
> >>> +
> >>> +  flash-leds: true
> >>> +  lens-focus: true
> >>
> >> No, where did you find this syntax. I do not see how you carefully fixed
> >> it. You need proper schema for these.
> >>
> >> Best regards,
> >> Krzysztof
> > 
> > I saw it used under sony,imx214.yaml and mipi-ccs.yaml. I thought referencing
> > video-interface-devices.yaml in this schema was correct because the flash-leds
> > and lens-focus properties are both specified in that file.
> 
> Ah, so you wanted to reference video-inteface-devices in top-level?
> Wasn't this already before? If that was missing then that's another
> thing to fix.
> 
> And then you need to use unevaluatedProperties: false. flash-leds needs
> constraints, number of items. lens-focus you simply remove.

I do have a preference in general for keeping 'additionalProperties:
false' and listing

  lens-focus: true

(with a reference to /schemas/media/video-interface-devices.yaml at the
top level of course).

The reason is that using 'unevaluatedProperties: false' will make all
the properties defined in video-interface-devices.yaml valid, even the
ones that don't apply to this device. This being said, most of the other
properties defined by video-interface-devices.yaml are applicable to
this device (the exceptions being 'leds' and 'led-names'), so I won't
fight for this in this specific case, even if I think it's better as a
general rule.

Regarding flash-leds, none of the existing bindings set a constraint on
the number of items. I'm not sure there are use cases for more than two,
but the number of flash LEDs is not an intrinsic properties of the image
sensor. I think listing

  flash-leds: true

is correct. Sakari may have more information.

-- 
Regards,

Laurent Pinchart