linux-kernel - Re: [PATCH] block: fix aux stat accumulation destination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <71df89fb-1766-40d5-8dd5-5d0c6f49519e@fnnas.com>
Date: Fri, 26 Dec 2025 00:44:37 +0800
From: "Yu Kuai" <yukuai@...as.com>
To: "shechenglong" <shechenglong@...sion.com>, <tj@...nel.org>, 
	<josef@...icpanda.com>, <axboe@...nel.dk>
Cc: <cgroups@...r.kernel.org>, <linux-block@...r.kernel.org>, 
	<linux-kernel@...r.kernel.org>, <stone.xulei@...sion.com>, 
	<chenjialong@...sion.com>, <yukuai@...as.com>
Subject: Re: [PATCH] block: fix aux stat accumulation destination

Hi,

在 2025/12/22 10:19, shechenglong 写道:
> Route bfqg_stats_add_aux() time accumulation into the destination
> stats object instead of the source, aligning with other stat fields.
>
> Signed-off-by: shechenglong <shechenglong@...sion.com>
> ---
>   block/bfq-cgroup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Please change the title and follow existing prefix:

block, bfq: fix aux stat accumulation destination

Otherwise, feel free to add:

Reviewed-by: Yu Kuai <yukuai@...as.com>

>
> diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
> index 9fb9f3533150..6a75fe1c7a5c 100644
> --- a/block/bfq-cgroup.c
> +++ b/block/bfq-cgroup.c
> @@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
>   	blkg_rwstat_add_aux(&to->merged, &from->merged);
>   	blkg_rwstat_add_aux(&to->service_time, &from->service_time);
>   	blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
> -	bfq_stat_add_aux(&from->time, &from->time);
> +	bfq_stat_add_aux(&to->time, &from->time);
>   	bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
>   	bfq_stat_add_aux(&to->avg_queue_size_samples,
>   			  &from->avg_queue_size_samples);

-- 
Thansk,
Kuai