linux-kernel - Re: [PATCH v3 01/15] include: dt-bindings: add LAN969x clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251225164512525907d8@mail.local>
Date: Thu, 25 Dec 2025 17:45:12 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Robert Marko <robert.marko@...tura.hr>, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org,
	nicolas.ferre@...rochip.com, claudiu.beznea@...on.dev,
	herbert@...dor.apana.org.au, davem@...emloft.net, vkoul@...nel.org,
	andi.shyti@...nel.org, lee@...nel.org, andrew+netdev@...n.ch,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	linusw@...nel.org, Steen.Hegelund@...rochip.com,
	daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com,
	olivia@...enic.com, radu_nicolae.pirea@....ro,
	richard.genoud@...tlin.com, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, broonie@...nel.org, mturquette@...libre.com,
	sboyd@...nel.org, lars.povlsen@...rochip.com,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	dmaengine@...r.kernel.org, linux-i2c@...r.kernel.org,
	netdev@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-serial@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-clk@...r.kernel.org,
	luka.perkov@...tura.hr
Subject: Re: [PATCH v3 01/15] include: dt-bindings: add LAN969x clock bindings

On 25/12/2025 17:25:07+0100, Alexandre Belloni wrote:
> On 25/12/2025 09:47:34+0100, Krzysztof Kozlowski wrote:
> > On 24/12/2025 15:01, Robert Marko wrote:
> > > On Wed, Dec 24, 2025 at 2:05 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> > >>
> > >> On 24/12/2025 11:30, Robert Marko wrote:
> > >>> On Wed, Dec 24, 2025 at 11:21 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> > >>>>
> > >>>> On Tue, Dec 23, 2025 at 09:16:12PM +0100, Robert Marko wrote:
> > >>>>> Add the required LAN969x clock bindings.
> > >>>>
> > >>>> I do not see clock bindings actually here. Where is the actual binding?
> > >>>> Commit msg does not help me at all to understand why you are doing this
> > >>>> without actual required bindings.
> > >>>
> > >>> I guess it is a bit confusing, there is no schema here, these are the
> > >>> clock indexes that
> > >>> reside in dt-bindings and are used by the SoC DTSI.
> > >>
> > >> I understand as not used by drivers? Then no ABI and there is no point
> > >> in putting them into bindings.
> > > 
> > > It is not included by the driver directly, but it requires these exact
> > > indexes to be passed
> > > so its effectively ABI.
> > 
> > How it requires the exact index? In what way? I do not see anything in
> > the gck driver using/relying on these values. Nothing. Please point me
> > to the line which directly uses these values.... or how many times I
> > will need to write this is not ABI?
> > 
> 
> The index here is the exact id that needs to be set in the PMC_PCR
> register and so it is dictated by the hardware.

This is the line you are looking for:
https://elixir.bootlin.com/linux/v6.18.2/source/drivers/clk/at91/clk-generated.c#L44

	regmap_write(gck->regmap, gck->layout->offset,
		     (gck->id & gck->layout->pid_mask));

> 
> 
> -- 
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com