linux-kernel - Re: [PATCH v2 5/6] docs: iio: add documentation for adf41513 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251227170453.66752435@jic23-huawei>
Date: Sat, 27 Dec 2025 17:06:05 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Rodrigo Alencar <455.rodrigo.alencar@...il.com>
Cc: rodrigo.alencar@...log.com, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-doc@...r.kernel.org, David Lechner <dlechner@...libre.com>, Andy
 Shevchenko <andy@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v2 5/6] docs: iio: add documentation for adf41513 driver



> > > +2.3 Reference Input Control
> > > +---------------------------
> > > +
> > > +The ``refin_frequency`` attribute allows control of the reference input
> > > +frequency when using a programmable reference clock. The supported range is
> > > +10 MHz to 800 MHz.  
> >
> > I'm not really sure why need this as opposed to having a standard clock
> > provide it.  What's the use case?  
> 
> I was thinking about, and for the application I am currently evaluating the part
> the reference signal comes from a DDS, and that signal is not a clock it is a
> series of chirp patterns. The important thing about this property is to set
> a center frequency for the DDS to work on. In that scenario the PLL will not
> really work as a frequency sythentizer, but as a frequency tracker of the
> varying reference. Problem is that I've realized that recently after putting
> together a device driver for the DDS. Therefore this property is still important,
> and I need to make the reference clock input as an optional property.
> I thought of making the DDS as a clock provider, but that center frequency
> would have a "virtual" meaning, not attached to the hardware configs.

Interesting use case!  I'm not really sure how we support it. I can think of a
a few approaches that might work. In some way it's a bit similar to an amplifier
in front of an ADC or other analog front end, just working in the frequency domain.
I've never been entirely happy with how we support those either though!

> 

> > > +2.5 Phase adjustment
> > > +--------------------
> > > +
> > > +The ``phase`` attribute allows adjustment of the output phase in degrees.  
> >
> > As per driver feedback, I don't think this is compliant with existing ABI.  
> 
> ABI is not in degrees? the attribute is named out_altvoltage0_phase

All angle things (including phase) in IIO are in Radians (we try to stick to SI
units). Check these in
Documentation/ABI/testing/sysfs-bus-iio*

Note that is not always as complete as it should be so if anything is missing
and in use we should add it.  We don't blanket add stuff the ABI construction
code allows as some cases will never occur in reality.

Jonathan