linux-kernel - Re: [PATCH v7 2/4] misc: fastrpc: Rename phys to dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hglfo45u7omm2g4e2yn6rl3kxcw7wwfdf3wl2wjibt7jedm2uu@5z4rxbtemgdc>
Date: Sat, 27 Dec 2025 19:15:27 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Kumari Pallavi <kumari.pallavi@....qualcomm.com>
Cc: kpallavi@....qualcomm.com, srini@...nel.org, amahesh@....qualcomm.com,
        arnd@...db.de, gregkh@...uxfoundation.org, robh@...nel.org,
        krzk+dt@...nel.org, conor+dt@...nel.org, quic_bkumar@...cinc.com,
        ekansh.gupta@....qualcomm.com, linux-kernel@...r.kernel.org,
        quic_chennak@...cinc.com, dri-devel@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        jingyi.wang@....qualcomm.com, aiqun.yu@....qualcomm.com,
        ktadakam@....qualcomm.com
Subject: Re: [PATCH v7 2/4] misc: fastrpc: Rename phys to dma_addr for clarity

On Fri, Dec 26, 2025 at 12:35:32PM +0530, Kumari Pallavi wrote:
> The fields buf->phys and map->phys currently store DMA addresses
> returned by dma_map_*() APIs, not physical addresses. This naming
> is misleading and may lead to incorrect assumptions about the
> address type and its translation.
> Rename these fields from phys to dma_addr to improve code clarity
> and align with kernel conventions for dma_addr_t usage.
> 
> Signed-off-by: Kumari Pallavi <kumari.pallavi@....qualcomm.com>
> ---
>  drivers/misc/fastrpc.c | 77 ++++++++++++++++++++++--------------------

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>

>  1 file changed, 41 insertions(+), 36 deletions(-)