linux-kernel - Re: [PATCH v3 3/5] pinctrl: samsung: add per-bank FLTCON offset to EXYNOS9_PIN_BANK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39a6dce9-ea6e-4a43-9bbc-54d822118db4@kernel.org>
Date: Sun, 28 Dec 2025 12:41:44 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Youngmin Nam <youngmin.nam@...sung.com>, s.nawrocki@...sung.com,
 alim.akhtar@...sung.com, linus.walleij@...aro.org, peter.griffin@...aro.org,
 semen.protsenko@...aro.org, ivo.ivanov.ivanov1@...il.com
Cc: ryu.real@...sung.com, d7271.choe@...sung.com, shin.son@...sung.com,
 jaewon02.kim@...sung.com, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/5] pinctrl: samsung: add per-bank FLTCON offset to
 EXYNOS9_PIN_BANK_* and fix tables

On 02/12/2025 10:36, Youngmin Nam wrote:
> Several Exynos9-era pin-bank tables were implicitly assuming that the
> filter control (FLTCON) registers are laid out contiguously from the
> EINT base offset. Per the TRMs this is not always true. FLTCON can live
> at a separate per-bank offset, and the current tables cause the driver
> to program the wrong FLTCON addresses for some banks.

"Can live" or "Does live"? Adding unused offset is not improving the
code. The implicit offset is fine, if it is correct.


Best regards,
Krzysztof