linux-kernel - Re: [PATCH v1 08/23] watchdog: rz: Discard pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a2fc1a6-343c-4fc3-ab5e-7c134216aa22@roeck-us.net>
Date: Sun, 28 Dec 2025 11:14:45 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Brian Norris <briannorris@...omium.org>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v1 08/23] watchdog: rz: Discard pm_runtime_put() return
 values

On Mon, Dec 22, 2025 at 09:07:46PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Failing a watchdog stop due to pm_runtime_put() returning a negative
> value is not particularly useful.
> 
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example.  It also happens when the kernel is
> configured with CONFIG_PM unset.
> 
> Accordingly, update rzg2l_wdt_stop() and rzv2h_wdt_stop() to simply
> discard the return value of pm_runtime_put().
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> 
> This patch is part of a series, but it doesn't depend on anything else
> in that series.  The last patch in the series depends on it.
> 
> It can be applied by itself and if you decide to do so, please let me
> know.
> 
> Otherwise, an ACK or equivalent will be appreciated, but also the lack
> of specific criticism will be eventually regarded as consent.
> 
> ---
>  drivers/watchdog/rzg2l_wdt.c |    4 +---
>  drivers/watchdog/rzv2h_wdt.c |    4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -132,9 +132,7 @@ static int rzg2l_wdt_stop(struct watchdo
>  	if (ret)
>  		return ret;
>  
> -	ret = pm_runtime_put(wdev->parent);
> -	if (ret < 0)
> -		return ret;
> +	pm_runtime_put(wdev->parent);
>  
>  	return 0;
>  }
> --- a/drivers/watchdog/rzv2h_wdt.c
> +++ b/drivers/watchdog/rzv2h_wdt.c
> @@ -174,9 +174,7 @@ static int rzv2h_wdt_stop(struct watchdo
>  	if (priv->of_data->wdtdcr)
>  		rzt2h_wdt_wdtdcr_count_stop(priv);
>  
> -	ret = pm_runtime_put(wdev->parent);
> -	if (ret < 0)
> -		return ret;
> +	pm_runtime_put(wdev->parent);
>  
>  	return 0;
>  }
> 
> 
>