linux-kernel - Re: [PATCH v1 09/23] watchdog: rzv2h_wdt: Discard pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b496da6-c6b7-431d-ae6c-34f5f682f944@roeck-us.net>
Date: Sun, 28 Dec 2025 11:15:02 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Brian Norris <briannorris@...omium.org>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v1 09/23] watchdog: rzv2h_wdt: Discard pm_runtime_put()
 return value

On Mon, Dec 22, 2025 at 09:09:22PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Failing device probe due to pm_runtime_put() returning an error is not
> particularly useful.
> 
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example.  It also happens when the kernel is
> configured with CONFIG_PM unset.
> 
> Accordingly, update rzt2h_wdt_wdtdcr_init() to simply discard the return
> value of pm_runtime_put() and return success to the caller after
> invoking that function.
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>