linux-kernel - Re: [PATCH] arm64: qcom: sm8750: Fix BAM DMA probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fab117be-d9a1-4f4a-b91d-e808c50960e2@oss.qualcomm.com>
Date: Mon, 29 Dec 2025 13:10:20 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Gaurav Kashyap <quic_gaurkash@...cinc.com>,
        Melody Olvera <quic_molvera@...cinc.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH] arm64: qcom: sm8750: Fix BAM DMA probing

On 12/29/25 12:57 PM, Krzysztof Kozlowski wrote:
> Bindings always required "qcom,num-ees" and "num-channels" properties,
> as reported by dtbs_check:
> 
>   sm8750-mtp.dtb: dma-controller@...4000 (qcom,bam-v1.7.4): 'anyOf' conditional failed, one must be fixed:
>     'qcom,powered-remotely' is a required property
>     'num-channels' is a required property
>     'qcom,num-ees' is a required property
>     'clocks' is a required property
>     'clock-names' is a required property
> 
> However since commit 5068b5254812 ("dmaengine: qcom: bam_dma: Fix DT
> error handling for num-channels/ees") missing properties are actually
> fatal and BAM does not probe:
> 
>   bam-dma-engine 1dc4000.dma-controller: num-channels unspecified in dt
>   bam-dma-engine 1dc4000.dma-controller: probe with driver bam-dma-engine failed with error -22
> 
> Fixes: eeb0f3e4ea67 ("arm64: dts: qcom: sm8750: Add QCrypto nodes")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad