linux-kernel - Re: [PATCH v2 03/11] drm/panel: Add LGD LH599QH3-EDB1 panel driver for Sony Xperia XZ3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD++jLkb5=i=XZdB=hc49hX1t6eP9=5tfv6Hg-5m5F0ghC=5_g@mail.gmail.com>
Date: Mon, 29 Dec 2025 13:33:44 +0100
From: Linus Walleij <linusw@...nel.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Sam Ravnborg <sam@...nborg.org>, 
	David Airlie <airlied@...il.com>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
	Jessica Zhang <jesszhan0024@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Simona Vetter <simona@...ll.ch>, 
	Casey Connolly <casey.connolly@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Simona Vetter <simona.vetter@...ll.ch>, 
	~postmarketos/upstreaming@...ts.sr.ht, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>, 
	Martin Botka <martin.botka@...ainline.org>, Jami Kettunen <jami.kettunen@...ainline.org>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Kuogee Hsieh <quic_khsieh@...cinc.com>, 
	Jessica Zhang <quic_jesszhan@...cinc.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	Dmitry Baryshkov <lumag@...nel.org>
Subject: Re: [PATCH v2 03/11] drm/panel: Add LGD LH599QH3-EDB1 panel driver
 for Sony Xperia XZ3

On Mon, Dec 29, 2025 at 12:21 PM Marijn Suijten
<marijn.suijten@...ainline.org> wrote:

> > Can you break it out to a subroutine?
> > lgd_lh599qh3_edb1_unlock()?
>
> Sure, though unsure where the "lock" sequence resides (and why it needs to be
> unlocked twice, unless this was autogenerated and is unnecessary, or implies a
> "flush" of sorts) or why it looks so familiar to the Samsung panels.
>
> Will rename it to lgd_lh599qh3_edb1_unlock_multi() and pass it a
> mipi_dsi_multi_context so that no extra return-code handling needs to be
> implemented.

I think extracting the unlock macros from the s6e* drivers and put into
a separate .h file is the best for starting to unify these drivers a bit,
but no big deal, I can do it later.

> > +/- this nitpick:
> > Reviewed-by: Linus Walleij <linusw@...nel.org>
>
> Just making sure, you reviewed the SOFEF01 driver with your Linaro address,
> which one do you prefer or should I keep this distinction?

The Linaro address stops working at the end of this year,
I'm sorry if my fingers sometimes type the wrong address...
linusw@...nel.org is what I should be using henceforth.

Yours,
Linus Walleij