linux-kernel - Re: [PATCH v2 04/11] dt-bindings: display: panel: Describe Samsung SOFEF01-M DDIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD++jLkb7my6Dt4CkqRjKZAMM6iT8YvzHZb67TRLt1jOEU0qdg@mail.gmail.com>
Date: Mon, 29 Dec 2025 13:37:51 +0100
From: Linus Walleij <linusw@...nel.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Sam Ravnborg <sam@...nborg.org>, 
	David Airlie <airlied@...il.com>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
	Jessica Zhang <jesszhan0024@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Simona Vetter <simona@...ll.ch>, 
	Casey Connolly <casey.connolly@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Simona Vetter <simona.vetter@...ll.ch>, 
	~postmarketos/upstreaming@...ts.sr.ht, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>, 
	Martin Botka <martin.botka@...ainline.org>, Jami Kettunen <jami.kettunen@...ainline.org>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Kuogee Hsieh <quic_khsieh@...cinc.com>, 
	Jessica Zhang <quic_jesszhan@...cinc.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	Dmitry Baryshkov <lumag@...nel.org>
Subject: Re: [PATCH v2 04/11] dt-bindings: display: panel: Describe Samsung
 SOFEF01-M DDIC

On Mon, Dec 29, 2025 at 12:53 PM Marijn Suijten
<marijn.suijten@...ainline.org> wrote:

> > Yes that's what I suspect.
>
> Do you still want me to drop it from the compatible, but definitely keep it in
> the driver filename unless we unify all of the drivers (hopefully in a later
> patch)?

The compatible should be as precise as possible, so indicate the
assembled display with display controller, typically
samsung,ams605dk01 etc, then the Linux driver is basically
a Linux intrinsic matter, but we would name that after the display
controller so as to make the basis of code sharing obvious between
the compatibles.

> > > Also, divergence of the driver commands got significant with the last two panels
> > > / three phones, though that might be down to vendor configuration/calibration.
> >
> > That's kind of normal. The defaults suffice for a while, then engineers
> > want to start poking at different voltages to the display to improve
> > and tweak things.
>
> Makes one wonder if the changes are down to the panel used, or vendor tuning
> when they started using these panels in their phones.  To note, I think I booted
> all these phones on the "original" SOFEF01 driver without problems, before
> ultimately implementing all diverging commands because I don't know if they're
> defaults, related to color tuning, timings, thermals, manufacturer tolerances or
> anything else.

Yeah a datasheet would really help :/

Samsung, if you're reading this, you know what to do: give us the
datasheets, pretty please with sugar on top.

Yours,
Linus Walleij