linux-kernel - Re: [PATCH v3 RESEND 01/14] Revert "fs: Remove NTFS classic"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVKi-ZiyIRj9IF1h@amir-ThinkPad-T480>
Date: Mon, 29 Dec 2025 17:49:13 +0200
From: Amir Goldstein <amir73il@...il.com>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@...radead.org,
	hch@....de, tytso@....edu, willy@...radead.org, jack@...e.cz,
	djwong@...nel.org, josef@...icpanda.com, sandeen@...deen.net,
	rgoldwyn@...e.com, xiang@...nel.org, dsterba@...e.com,
	pali@...nel.org, ebiggers@...nel.org, neil@...wn.name,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com,
	gunho.lee@....com
Subject: Re: [PATCH v3 RESEND 01/14] Revert "fs: Remove NTFS classic"

On Mon, Dec 29, 2025 at 08:24:33PM +0900, Namjae Jeon wrote:
> This reverts commit 7ffa8f3d30236e0ab897c30bdb01224ff1fe1c89.
> ---
>  fs/ntfs/aops.c     | 1744 ++++++++++++++++++++++++
>  fs/ntfs/aops.h     |   88 ++
>  fs/ntfs/attrib.c   | 2624 ++++++++++++++++++++++++++++++++++++
>  fs/ntfs/attrib.h   |  102 ++
>  fs/ntfs/bitmap.c   |  179 +++
>  fs/ntfs/bitmap.h   |  104 ++
>  fs/ntfs/collate.c  |  110 ++
>  fs/ntfs/collate.h  |   36 +
>  fs/ntfs/compress.c |  950 +++++++++++++
>  fs/ntfs/debug.c    |  159 +++
>  fs/ntfs/debug.h    |   57 +
>  fs/ntfs/dir.c      | 1540 +++++++++++++++++++++
>  fs/ntfs/dir.h      |   34 +
>  fs/ntfs/endian.h   |   79 ++
>  fs/ntfs/file.c     | 1997 +++++++++++++++++++++++++++
>  fs/ntfs/index.c    |  440 ++++++
>  fs/ntfs/index.h    |  134 ++
>  fs/ntfs/inode.c    | 3102 ++++++++++++++++++++++++++++++++++++++++++
>  fs/ntfs/inode.h    |  310 +++++
>  fs/ntfs/layout.h   | 2421 +++++++++++++++++++++++++++++++++
>  fs/ntfs/lcnalloc.c | 1000 ++++++++++++++
>  fs/ntfs/lcnalloc.h |  131 ++
>  fs/ntfs/logfile.c  |  849 ++++++++++++
>  fs/ntfs/logfile.h  |  295 ++++
>  fs/ntfs/malloc.h   |   77 ++
>  fs/ntfs/mft.c      | 2907 ++++++++++++++++++++++++++++++++++++++++
>  fs/ntfs/mft.h      |  110 ++
>  fs/ntfs/mst.c      |  189 +++
>  fs/ntfs/namei.c    |  392 ++++++
>  fs/ntfs/ntfs.h     |  150 +++
>  fs/ntfs/quota.c    |  103 ++
>  fs/ntfs/quota.h    |   21 +
>  fs/ntfs/runlist.c  | 1893 ++++++++++++++++++++++++++
>  fs/ntfs/runlist.h  |   88 ++
>  fs/ntfs/super.c    | 3202 ++++++++++++++++++++++++++++++++++++++++++++
>  fs/ntfs/sysctl.c   |   58 +
>  fs/ntfs/sysctl.h   |   27 +
>  fs/ntfs/time.h     |   89 ++
>  fs/ntfs/types.h    |   55 +
>  fs/ntfs/unistr.c   |  384 ++++++
>  fs/ntfs/upcase.c   |   73 +
>  fs/ntfs/volume.h   |  164 +++
>  42 files changed, 28467 insertions(+)
>  create mode 100644 fs/ntfs/aops.c
>  create mode 100644 fs/ntfs/aops.h
>  create mode 100644 fs/ntfs/attrib.c
>  create mode 100644 fs/ntfs/attrib.h
>  create mode 100644 fs/ntfs/bitmap.c
>  create mode 100644 fs/ntfs/bitmap.h
>  create mode 100644 fs/ntfs/collate.c
>  create mode 100644 fs/ntfs/collate.h
>  create mode 100644 fs/ntfs/compress.c
>  create mode 100644 fs/ntfs/debug.c
>  create mode 100644 fs/ntfs/debug.h
>  create mode 100644 fs/ntfs/dir.c
>  create mode 100644 fs/ntfs/dir.h
>  create mode 100644 fs/ntfs/endian.h
>  create mode 100644 fs/ntfs/file.c
>  create mode 100644 fs/ntfs/index.c
>  create mode 100644 fs/ntfs/index.h
>  create mode 100644 fs/ntfs/inode.c
>  create mode 100644 fs/ntfs/inode.h
>  create mode 100644 fs/ntfs/layout.h
>  create mode 100644 fs/ntfs/lcnalloc.c
>  create mode 100644 fs/ntfs/lcnalloc.h
>  create mode 100644 fs/ntfs/logfile.c
>  create mode 100644 fs/ntfs/logfile.h
>  create mode 100644 fs/ntfs/malloc.h
>  create mode 100644 fs/ntfs/mft.c
>  create mode 100644 fs/ntfs/mft.h
>  create mode 100644 fs/ntfs/mst.c
>  create mode 100644 fs/ntfs/namei.c
>  create mode 100644 fs/ntfs/ntfs.h
>  create mode 100644 fs/ntfs/quota.c
>  create mode 100644 fs/ntfs/quota.h
>  create mode 100644 fs/ntfs/runlist.c
>  create mode 100644 fs/ntfs/runlist.h
>  create mode 100644 fs/ntfs/super.c
>  create mode 100644 fs/ntfs/sysctl.c
>  create mode 100644 fs/ntfs/sysctl.h
>  create mode 100644 fs/ntfs/time.h
>  create mode 100644 fs/ntfs/types.h
>  create mode 100644 fs/ntfs/unistr.c
>  create mode 100644 fs/ntfs/upcase.c
>  create mode 100644 fs/ntfs/volume.h
> 

Namje,

This is a partial revert, something that should be mention in commit
message.

But also, I think you should include more of the original revert, like
the docs and MAINTAINERS entry, which you added later, sometimes inside
unrelated patches.

The only think that you need to omit from the revert in the Makefile and
Kconfig changes, so that ntfs code remains dormant until the end of the
series.

Thanks,
Amir.