linux-kernel - Re: [PATCH] phy: Kconfig: spacemit: add COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVKy87c7afpWIx33@vaman>
Date: Mon, 29 Dec 2025 22:27:23 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Alex Elder <elder@...cstar.com>
Cc: neil.armstrong@...aro.org, dlan@...too.org, pjw@...nel.org,
	palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr,
	guodong@...cstar.com, linux-phy@...ts.infradead.org,
	spacemit@...ts.linux.dev, linux-riscv@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] phy: Kconfig: spacemit: add COMMON_CLK dependency

On 26-12-25, 11:32, Alex Elder wrote:
> The SpacemiT PCIe PHY driver depends on the common clock framework.
> Not specifying that led to a failure when doing a COMPILE_TEST build
> for the SPARC architecture.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/
> Signed-off-by: Alex Elder <elder@...cstar.com>
> ---
> Note:  This is based on phy/next, which I find doesn't currently build
>        cleanly using "arch/riscv/configs/defconfig".

I dont build rsicv, I should add that. What is the failure you see,
looking at changes I dont see anything that might break this

> 
>  drivers/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index aa2d30e0e3261..3bc7378ea8658 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -104,6 +104,7 @@ config PHY_NXP_PTN3222
>  config PHY_SPACEMIT_K1_PCIE
>  	tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC"
>  	depends on ARCH_SPACEMIT || COMPILE_TEST
> +	depends on COMMON_CLK
>  	depends on HAS_IOMEM
>  	depends on OF
>  	select GENERIC_PHY
> 
> base-commit: 27287e3b52b5954b73203d32ee76ffd5f53f5074
> -- 
> 2.48.1

-- 
~Vinod