linux-kernel - Re: [PATCH] phy: Kconfig: spacemit: add COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85d045be-7b18-4bf5-b6a1-09e723cad2a0@riscstar.com>
Date: Mon, 29 Dec 2025 11:51:04 -0600
From: Alex Elder <elder@...cstar.com>
To: Vinod Koul <vkoul@...nel.org>
Cc: neil.armstrong@...aro.org, dlan@...too.org, pjw@...nel.org,
 palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr,
 guodong@...cstar.com, linux-phy@...ts.infradead.org,
 spacemit@...ts.linux.dev, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] phy: Kconfig: spacemit: add COMMON_CLK dependency

On 12/29/25 10:57 AM, Vinod Koul wrote:
> On 26-12-25, 11:32, Alex Elder wrote:
>> The SpacemiT PCIe PHY driver depends on the common clock framework.
>> Not specifying that led to a failure when doing a COMPILE_TEST build
>> for the SPARC architecture.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/
>> Signed-off-by: Alex Elder <elder@...cstar.com>
>> ---
>> Note:  This is based on phy/next, which I find doesn't currently build
>>         cleanly using "arch/riscv/configs/defconfig".
> 
> I dont build rsicv, I should add that. What is the failure you see,
> looking at changes I dont see anything that might break this


The clock calls are not defined in the SPARC environment.

   phy-spacemit-k1-pcie.o: in function `k1_pcie_phy_pll_setup':
   phy-spacemit-k1-pcie.c:299: undefined reference to `devm_clk_hw_register'
   phy-spacemit-k1-pcie.c:306: undefined reference to `devm_clk_hw_get_clk'

https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/

(I now realize you can just click on the "Closes" link.)

					-Alex

>>
>>   drivers/phy/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index aa2d30e0e3261..3bc7378ea8658 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -104,6 +104,7 @@ config PHY_NXP_PTN3222
>>   config PHY_SPACEMIT_K1_PCIE
>>   	tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC"
>>   	depends on ARCH_SPACEMIT || COMPILE_TEST
>> +	depends on COMMON_CLK
>>   	depends on HAS_IOMEM
>>   	depends on OF
>>   	select GENERIC_PHY
>>
>> base-commit: 27287e3b52b5954b73203d32ee76ffd5f53f5074
>> -- 
>> 2.48.1
>