linux-kernel - Re: [PATCH v2] staging: gpib: Fix memory leak in ni_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251230032953.919177-1-zilin@seu.edu.cn>
Date: Tue, 30 Dec 2025 03:29:53 +0000
From: Zilin Guan <zilin@....edu.cn>
To: gregkh@...uxfoundation.org
Cc: dpenkler@...il.com,
	jianhao.xu@....edu.cn,
	linux-kernel@...r.kernel.org,
	matchstick@...erthere.org,
	mingo@...nel.org,
	tglx@...utronix.de,
	zilin@....edu.cn
Subject: Re: [PATCH v2] staging: gpib: Fix memory leak in ni_usb_init()

On Mon, Dec 29, 2025 at 04:28:21PM+0100, Greg KH wrote:
> As the code is no longer in staging, that prefix does not need to be
> ther.

Thanks for pointing that out. I will drop the prefix in v3.

> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb_gpib.c
> > index 1f8412de9fa3..2352c6817440 100644
> > --- a/drivers/gpib/ni_usb/ni_usb_gpib.c
> > +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c
> > @@ -1799,10 +1799,12 @@ static int ni_usb_init(struct gpib_board *board)
> >  		return -ENOMEM;
> >  
> >  	writes_len = ni_usb_setup_init(board, writes);
> > -	if (writes_len)
> > -		retval = ni_usb_write_registers(ni_priv, writes, writes_len, &ibsta);
> > -	else
> > +	if (!writes_len) {
> > +		kfree(writes);
> >  		return -EFAULT;
> 
> This is not the correct error value, it should only happen if copy
> to/from user fails.  I know it's not the issue here, just noticed this.
> 
> And why doesn't ni_usb_setup_init() return an error value that should be
> propagated upward?
> 
> thanks,
> 
> greg k-h

Thanks for the suggestion. I will modify ni_usb_setup_init() to return 
proper error codes and propagate them in v3.

Thanks,
Zilin Guan