linux-kernel - Re: [PATCH] Fix PTP driver warnings by removing settime64 check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67fb6d48-148f-49c7-86aa-4f4244ec6f31@lunn.ch>
Date: Tue, 30 Dec 2025 11:59:16 +0100
From: Andrew Lunn <andrew@...n.ch>
To: TINSAE TADESSE GUTEMA <tinsaetadesse2015@...il.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, richardcochran@...il.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix PTP driver warnings by removing settime64 check

> This patch resolves warnings triggered when either gettimex64 or settime64 are
> NULL.
> The CONFIG_PTP_1588_CLOCK=y option enables PTP support for all Ethernet
> devices.
> In systems with Intel-based network devices, both the iwlwifi and e1000e
> modules attempt to register clocks, resulting in calls to ptp_clock_register in
> drivers/ptp/ptp_clock.c that produce warnings if any function pointers are
> uninitialized. 
> 
> Without this patch, the following warning is logged during registration:
> 
>     info->n_alarm > PTP_MAX_ALARMS || (!info->gettimex64 && !info->gettime64) |
>     | !info->settime64
>     WARNING: drivers/ptp/ptp_clock.c:325 at ptp_clock_register+0x54/0xb70, CPU#
>     2: NetworkManager/1102
>     ...
>     iwlwifi 0000:00:14.3: Failed to register PHC clock (-22)

It seems this patch is no longer needed. But FYI, this explanation
should of been in the commit message. The commit message should
explain why a change is needed.


    Andrew

---
pw-bot: cr