linux-kernel - Re: [PATCH 1/3] platform/x86: asus-wmi: explicitly mark more code with CONFIG_ASUS_WMI_DEPRECATED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb0f4db5-a169-4e28-882b-346e595c81b5@gmail.com>
Date: Tue, 30 Dec 2025 14:53:26 +0100
From: Denis Benato <benato.denis96@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Denis Benato <denis.benato@...ux.dev>, LKML
 <linux-kernel@...r.kernel.org>, platform-driver-x86@...r.kernel.org,
 Hans de Goede <hansg@...nel.org>, "Luke D . Jones" <luke@...nes.dev>,
 Mateusz Schyboll <dragonn@...pl>
Subject: Re: [PATCH 1/3] platform/x86: asus-wmi: explicitly mark more code
 with CONFIG_ASUS_WMI_DEPRECATED_ATTRS

On 12/30/25 14:41, Ilpo Järvinen wrote:
> On Tue, 30 Dec 2025, Denis Benato wrote:
>> On 12/29/25 11:06, Ilpo Järvinen wrote:
>>> On Thu, 25 Dec 2025, Denis Benato wrote:
>>>
>>>> Be more explicit in code that will be excluded when compiling
>>>> with CONFIG_ASUS_WMI_DEPRECATED_ATTRS disabled.
>>> Does this result in build fails or warnings? If that's the case, it should 
>>> be mentioned in the changelog + Fixes tag added.
>> Hi,
>>
>> Sadly no, despite a property in a struct instantiated only once
>> being forcefully set to false no warning is emitted by neither
>> clang nor gcc :(
> Ah, I was mainly expecting unused function warning but apparently since it 
> was still being "used" it obviously won't trigger that warning.
>
Plus if gcc/clang could have catched it build bots would have done so
when posting the asus-armoury series as they catched other things.