linux-kernel - Re: [PATCH] of: unittest: Fix memory leak in unittest_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251230180945.GA885892-robh@kernel.org>
Date: Tue, 30 Dec 2025 12:09:45 -0600
From: Rob Herring <robh@...nel.org>
To: Zilin Guan <zilin@....edu.cn>
Cc: saravanak@...gle.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jianhao Xu <jianhao.xu@....edu.cn>
Subject: Re: [PATCH] of: unittest: Fix memory leak in unittest_data_add()

On Tue, Dec 30, 2025 at 06:58:59AM +0000, Zilin Guan wrote:
> In unittest_data_add(), if of_resolve_phandles() fails, the allocated
> unittest_data is not freed, leading to a memory leak.
> 
> Fix this by freeing unittest_data in the error handling path before
> returning.

Please change the function to use cleanup.h instead so this bug can't 
happen again.

> 
> Fixes: 2eb46da2a760 ("of/selftest: Use the resolver to fixup phandles")
> Co-developed-by: Jianhao Xu <jianhao.xu@....edu.cn>
> Signed-off-by: Jianhao Xu <jianhao.xu@....edu.cn>
> Signed-off-by: Zilin Guan <zilin@....edu.cn>
> ---
>  drivers/of/unittest.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 388e9ec2cccf..8622a8ac1814 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -2031,6 +2031,7 @@ static int __init unittest_data_add(void)
>  	rc = of_resolve_phandles(unittest_data_node);
>  	if (rc) {
>  		pr_err("%s: Failed to resolve phandles (rc=%i)\n", __func__, rc);
> +		kfree(unittest_data);
>  		rc = -EINVAL;
>  		goto unlock;
>  	}
> -- 
> 2.34.1
>