linux-kernel - Re: [PATCH V3 2/4] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d724c6d3-0dff-43a3-827b-fdf8be2a6a0d@kernel.org>
Date: Wed, 31 Dec 2025 08:53:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Ram Kumar Dwivedi <ram.dwivedi@....qualcomm.com>
Cc: mani@...nel.org, alim.akhtar@...sung.com, avri.altman@....com,
 bvanassche@....org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, James.Bottomley@...senpartnership.com,
 martin.petersen@...cle.com, anjana.hari@....qualcomm.com,
 linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 2/4] dt-bindings: ufs: Document bindings for SA8255P
 UFS Host Controller

On 31/12/2025 06:19, Dmitry Baryshkov wrote:
> On Wed, Dec 31, 2025 at 10:25:51AM +0530, Ram Kumar Dwivedi wrote:
>> Document the device tree bindings for UFS host controller on
>> Qualcomm SA8255P platform which integrates firmware-managed
>> resources.
>>
>> The platform firmware implements the SCMI server and manages
>> resources such as the PHY, clocks, regulators and resets via the
>> SCMI power protocol. As a result, the OS-visible DT only describes
>> the controller’s MMIO, interrupt, IOMMU and power-domain interfaces.
>>
>> The generic "qcom,ufshc" and "jedec,ufs-2.0" compatible strings are
>> removed from the binding, since this firmware managed design won't
>> be compatible with the drivers doing full resource management.
>>
>> Co-developed-by: Anjana Hari <anjana.hari@....qualcomm.com>
>> Signed-off-by: Anjana Hari <anjana.hari@....qualcomm.com>
>> Signed-off-by: Ram Kumar Dwivedi <ram.dwivedi@....qualcomm.com>
>> ---
>>  .../bindings/ufs/qcom,sa8255p-ufshc.yaml      | 62 +++++++++++++++++++
>>  1 file changed, 62 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
>>
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +    soc {
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
> 
> This didn't really improve. You don't need 'soc' node at all. Please
> drop it.
> 

It was already asked by Bjorn, then I reminded that. So I wonder if
repeating three times will work?

Feels like a waste of our time if same feedback has to be repeated three
times.

Best regards,
Krzysztof