[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1824a665-04b7-42af-b338-46c851a3986e@oss.qualcomm.com>
Date: Tue, 6 Jan 2026 19:13:05 +0530
From: Ram Kumar Dwivedi <ram.dwivedi@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: mani@...nel.org, alim.akhtar@...sung.com, avri.altman@....com,
bvanassche@....org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, James.Bottomley@...senpartnership.com,
martin.petersen@...cle.com, anjana.hari@....qualcomm.com,
linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 2/4] dt-bindings: ufs: Document bindings for SA8255P
UFS Host Controller
On 31-Dec-25 1:23 PM, Krzysztof Kozlowski wrote:
> On 31/12/2025 06:19, Dmitry Baryshkov wrote:
>> On Wed, Dec 31, 2025 at 10:25:51AM +0530, Ram Kumar Dwivedi wrote:
>>> Document the device tree bindings for UFS host controller on
>>> Qualcomm SA8255P platform which integrates firmware-managed
>>> resources.
>>>
>>> The platform firmware implements the SCMI server and manages
>>> resources such as the PHY, clocks, regulators and resets via the
>>> SCMI power protocol. As a result, the OS-visible DT only describes
>>> the controller’s MMIO, interrupt, IOMMU and power-domain interfaces.
>>>
>>> The generic "qcom,ufshc" and "jedec,ufs-2.0" compatible strings are
>>> removed from the binding, since this firmware managed design won't
>>> be compatible with the drivers doing full resource management.
>>>
>>> Co-developed-by: Anjana Hari <anjana.hari@....qualcomm.com>
>>> Signed-off-by: Anjana Hari <anjana.hari@....qualcomm.com>
>>> Signed-off-by: Ram Kumar Dwivedi <ram.dwivedi@....qualcomm.com>
>>> ---
>>> .../bindings/ufs/qcom,sa8255p-ufshc.yaml | 62 +++++++++++++++++++
>>> 1 file changed, 62 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
>>>
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + soc {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>
>> This didn't really improve. You don't need 'soc' node at all. Please
>> drop it.
>>
>
> It was already asked by Bjorn, then I reminded that. So I wonder if
> repeating three times will work?
>
> Feels like a waste of our time if same feedback has to be repeated three
> times.
Hi Krzysztof and Dmitry,
I have removed the address-cells and size-cells in latest patchset.
Thanks,
Ram.
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists