linux-kernel - Re: [PATCH 1/5] arm: dts: mstar: breadbee: Correct regulator names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50439d25-55a3-4d76-8864-81132db7598c@kernel.org>
Date: Wed, 31 Dec 2025 10:49:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Palmer <daniel@...f.com>, krzk+dt@...nel.org,
 romain.perier@...il.com, robh@...nel.org, conor+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] arm: dts: mstar: breadbee: Correct regulator names

On 31/12/2025 03:54, Daniel Palmer wrote:
> The regulator names had a "@<n>" in them so the dt validation
> stuff wanted a reg property. Fix the names to match what the regulator
> is for and remove the "@<n>" bit.
> 
> Signed-off-by: Daniel Palmer <daniel@...f.com>
> ---
>  .../boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi  | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> index 507ff2fba837..aedea0fbbce6 100644
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> @@ -7,7 +7,7 @@
>  #include <dt-bindings/gpio/gpio.h>
>  
>  / {
> -	vcc_core: fixedregulator@0 {
> +	vcc_core: reg-core {


If renaming this then rather use one of the approved names, so either
"regulator-foo" or "regulator-XvY" (which matches current format
recommendation: 'regulator-[0-9]v[0-9]')

https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml

Best regards,
Krzysztof