linux-kernel - Re: [PATCH v4 3/9] drm: verisilicon: add a driver for Verisilicon display controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFCGV315JITK.1TXTXWUOMLMB9@bootlin.com>
Date: Wed, 31 Dec 2025 15:20:19 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Icenowy Zheng" <zhengxingda@...as.ac.cn>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Drew Fustini" <fustini@...nel.org>, "Guo
 Ren" <guoren@...nel.org>, "Fu Wei" <wefu@...hat.com>, "Philipp Zabel"
 <p.zabel@...gutronix.de>, "Heiko Stuebner" <heiko@...ech.de>, "Andrzej
 Hajda" <andrzej.hajda@...el.com>, "Neil Armstrong"
 <neil.armstrong@...aro.org>, "Robert Foss" <rfoss@...nel.org>, "Laurent
 Pinchart" <Laurent.pinchart@...asonboard.com>, "Jonas Karlman"
 <jonas@...boo.se>, "Jernej Skrabec" <jernej.skrabec@...il.com>, "Michal
 Wilczynski" <m.wilczynski@...sung.com>
Cc: "Han Gao" <rabenda.cn@...il.com>, "Yao Zi" <ziyao@...root.org>,
 <dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>, "Icenowy
 Zheng" <uwu@...nowy.me>
Subject: Re: [PATCH v4 3/9] drm: verisilicon: add a driver for Verisilicon
 display controllers

On Wed Dec 24, 2025 at 5:11 PM CET, Icenowy Zheng wrote:
> From: Icenowy Zheng <uwu@...nowy.me>
>
> This is a from-scratch driver targeting Verisilicon DC-series display
> controllers, which feature self-identification functionality like their
> GC-series GPUs.
>
> Only DC8200 is being supported now, and only the main framebuffer is set
> up (as the DRM primary plane). Support for more DC models and more
> features is my further targets.
>
> As the display controller is delivered to SoC vendors as a whole part,
> this driver does not use component framework and extra bridges inside a
> SoC is expected to be implemented as dedicated bridges (this driver
> properly supports bridge chaining).
>
> Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> Signed-off-by: Icenowy Zheng <zhengxingda@...as.ac.cn>

[...]

> +++ b/drivers/gpu/drm/verisilicon/vs_bridge.h

> +struct vs_bridge {
> +	struct drm_bridge base;
> +	struct drm_encoder *enc;
> +	struct drm_connector *conn;
> +
> +	struct vs_crtc *crtc;
> +	struct drm_bridge *next;

It is a common convention to call this 'next_bridge'. This makes it easier
to understand but also to grep and find similar patterns.

For info, we are working to move to 'struct drm_bridge::next_bridge' [0] as
you can see from example patches like [1]. However this currently applies
only to drivers using of_drm_find_bridge(), so it does not affect your
driver.

I'm sorry I have seen your patch only at v4.

[0] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/3fdeae134ba956aacbd87d5532c025913c98fc49
[1] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/8f92a5fcbfe33f86b08f5f74dcc58a41425ea8c0

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com