linux-kernel - Re: [PATCH 5/5] watchdog: menz069_wdt: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4d03910-fda1-425b-8628-bf82d306527b@roeck-us.net>
Date: Wed, 31 Dec 2025 06:21:14 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Javier Rodriguez <josejavier.rodriguez@...gon.com>
Cc: linux-kernel@...r.kernel.org,
	Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>,
	Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>,
	Johannes Thumshirn <jth@...nel.org>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Andy Shevchenko <andriy.shevchenko@...el.com>,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 5/5] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS

On Tue, Dec 30, 2025 at 10:59:28PM +0100, Javier Rodriguez wrote:
> From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> 
> The MODULE_ALIAS() is redundant since the module alias is now
> automatically generated from the MODULE_DEVICE_TABLE().
> 

Unless the generated alias is not "mcb:16z069", and it is unlikely that
it is. That means it is not really redundant.

Guenter

> Remove the explicit alias.
> 
> No functional change intended.
> 
> Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
> Cc: Johannes Thumshirn <jth@...nel.org>
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Andy Shevchenko <andriy.shevchenko@...el.com>
> Cc: linux-watchdog@...r.kernel.org
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> ---
>  drivers/watchdog/menz69_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
> index 6e5e4e5c0b56..3fe23451135d 100644
> --- a/drivers/watchdog/menz69_wdt.c
> +++ b/drivers/watchdog/menz69_wdt.c
> @@ -163,5 +163,4 @@ module_mcb_driver(men_z069_driver);
>  MODULE_AUTHOR("Johannes Thumshirn <jth@...nel.org>");
>  MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
>  MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("mcb:16z069");
>  MODULE_IMPORT_NS("MCB");
> -- 
> 2.52.0