linux-kernel - Re: [PATCH 3/5] iio: adc: men_z188_adc: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251231180057.7be409a8@jic23-huawei>
Date: Wed, 31 Dec 2025 18:00:57 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Rodriguez <josejavier.rodriguez@...gon.com>
Cc: linux-kernel@...r.kernel.org, Jose Javier Rodriguez Barbarin
 <dev-josejavier.rodriguez@...gon.com>, Jorge Sanjuan Garcia
 <dev-jorge.sanjuangarcia@...gon.com>, Andy Shevchenko
 <andriy.shevchenko@...el.com>, linux-iio@...r.kernel.org
Subject: Re: [PATCH 3/5] iio: adc: men_z188_adc: drop unneeded MODULE_ALIAS

On Tue, 30 Dec 2025 22:59:26 +0100
Javier Rodriguez <josejavier.rodriguez@...gon.com> wrote:

> From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> 
> The MODULE_ALIAS() is redundant since the module alias is now
> automatically generated from the MODULE_DEVICE_TABLE().
> 
> Remove the explicit alias.
> 
> No functional change intended.
> 
> Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")

From the patch description I'm not seeing how this is a fix?
Seems like cleanup of unnecessary code given what you have written above.

> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Andy Shevchenko <andriy.shevchenko@...el.com>
> Cc: linux-iio@...r.kernel.org
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> ---
>  drivers/iio/adc/men_z188_adc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
> index cf8a8c0412ec..90919d282e7b 100644
> --- a/drivers/iio/adc/men_z188_adc.c
> +++ b/drivers/iio/adc/men_z188_adc.c
> @@ -171,5 +171,4 @@ module_mcb_driver(men_z188_driver);
>  MODULE_AUTHOR("Johannes Thumshirn <johannes.thumshirn@....de>");
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("IIO ADC driver for MEN 16z188 ADC Core");
> -MODULE_ALIAS("mcb:16z188");
>  MODULE_IMPORT_NS("MCB");