linux-kernel - Re: [PATCH v2 1/6] staging: iio: ad9832: cleanup dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251231180238.7d564a7f@jic23-huawei>
Date: Wed, 31 Dec 2025 18:02:38 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Tomas Borquez <tomasborquez13@...il.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 1/6] staging: iio: ad9832: cleanup dev_err_probe()

On Wed, 31 Dec 2025 00:47:43 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Tue, Dec 30, 2025 at 10:35 PM Tomas Borquez <tomasborquez13@...il.com> wrote:
> >
> > Cleanup dev_err_probe() by keeping messages consistent and adding
> > error message for clock acquisition failure.  
> 
> AFAICS this does two things, the second one is reuse of the temporary
> variable for struct device.
> 
Agreed. Ideal patch break up would be to not just mention
them but do the struct device *dev first, then the dev_err_probe()
change.