linux-kernel - Re: [PATCH v5 20/21] regulator: s2mps11: more descriptive gpio consumer name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mcn4MN5Mp-7avR1fVn=V1HFCimM5FM8jx4bXvCpjjVzNg@mail.gmail.com>
Date: Fri, 2 Jan 2026 11:08:57 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: André Draszik <andre.draszik@...aro.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Linus Walleij <linusw@...nel.org>, Peter Griffin <peter.griffin@...aro.org>, 
	Will McVicker <willmcvicker@...gle.com>, Juan Yescas <jyescas@...gle.com>, kernel-team@...roid.com, 
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v5 20/21] regulator: s2mps11: more descriptive gpio
 consumer name

On Sat, Dec 27, 2025 at 1:24 PM André Draszik <andre.draszik@...aro.org> wrote:
>
> Currently, GPIOs claimed by this driver for external rail control
> all show up with "s2mps11-regulator" as consumer, which is not
> very informative.
>
> Switch to using the regulator name via desc->name instead, using the
> device name as fallback.
>
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> ---
>  drivers/regulator/s2mps11.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
> index f068b795ab51845bddac84eca08be0efdcf4f164..178a032c0dc192874118906aee45441a1bbd8515 100644
> --- a/drivers/regulator/s2mps11.c
> +++ b/drivers/regulator/s2mps11.c
> @@ -362,7 +362,8 @@ static int s2mps11_of_parse_gpiod(struct device_node *np,
>         ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), con_id, 0,
>                                            GPIOD_OUT_HIGH |
>                                            GPIOD_FLAGS_BIT_NONEXCLUSIVE,
> -                                          "s2mps11-regulator");
> +                                          desc->name
> +                                          ? : dev_name(config->dev));
>         if (IS_ERR(ena_gpiod)) {
>                 ret = PTR_ERR(ena_gpiod);
>
>
> --
> 2.52.0.351.gbe84eed79e-goog
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>