linux-kernel - Re: fs/file_attr.c:263:9: error: unexpected token, expected comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260102102730.GH1712166@ZenIV>
Date: Fri, 2 Jan 2026 10:27:30 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: kernel test robot <lkp@...el.com>
Cc: Andrey Albershteyn <aalbersh@...nel.org>, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Christian Brauner <brauner@...nel.org>,
	Amir Goldstein <amir73il@...il.com>,
	"Darrick J. Wong" <djwong@...nel.org>, Jan Kara <jack@...e.cz>
Subject: Re: fs/file_attr.c:263:9: error: unexpected token, expected comma

On Fri, Jan 02, 2026 at 09:31:14AM +0000, Al Viro wrote:
> On Thu, Jan 01, 2026 at 09:41:43AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   9528d5c091c59b408a754a1823cf0942069867cc
> > commit: 2f952c9e8fe13c6ee15c05189f1f87c1a70b866c fs: split fileattr related helpers into separate file
> > date:   6 months ago
> > config: mips-randconfig-r051-20251231 (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202601010950.QjCTROwO-lkp@intel.com/
> 
> It has nothing whatsoever to do with the commit in question; I would be
> very surprised if the same build was not full of identical errors all
> over the place, wherever we happen to use put_user() or get_user().
> 
> Basically, you've stumbled across a mips config that breaks something
> in their asm/uaccess.h; apparently 32bit with EVA, bringing the macro
> horrors from asm-eva.h into play.

FWIW, error message is misleading - it's complaining about the stuff
coming out of inline asm; the token in question is assembler rather than
C one.

Does clang/mips even know about .set eva, seeing that it insists on examining
the inline asm for assembler validity?

Considering this

; cat >/tmp/foo.c <<'EOF'
void f(void)
{
        asm volatile(".set push\n.set eva\n.set pop");
}
EOF
; clang --target=mipsel-linux-gnu -mabi=32 -EL -march=mips32r2 -c /tmp/foo.c
/tmp/foo.c:3:27: error: unexpected token, expected comma
    3 |         asm volatile(".set push\n.set eva\n.set pop");
      |                                  ^
<inline asm>:2:9: note: instantiated into assembly here
    2 | .set eva
      |         ^
1 error generated.
;

I rather suspect that it doesn't...  FWIW, replacing clang --target=mipsel-linux-gnu
with mips-linux-gnu-gcc works as expected.  If you turn that mips32r2 into e.g.
mips32, gcc will spew
/tmp/ccGqqn3X.s: Assembler messages:
/tmp/ccGqqn3X.s:26: Warning: the `eva' extension requires MIPS32 revision 2 or greater