linux-kernel - Re: [PATCH 0/3] scripts: generate_rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFEDG6TK5AY9.1Y9EPEYQLMCMX@kernel.org>
Date: Fri, 02 Jan 2026 21:05:09 +0100
From: "Benno Lossin" <lossin@...nel.org>
To: "Tamir Duberstein" <tamird@...nel.org>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] scripts: generate_rust_analyzer: match
 rust/Makefile

On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
> @Benno would you mind having a look at this series?

Oh wow this is an old series! Sorry for missing it.

I'm not maintaining the build system for pin-init, but from my side the
changes look okay. The commit messages are missing some context though:
why do we need these dependency edges? etc. If you fix that you can add

Acked-by: Benno Lossin <lossin@...nel.org>

Also note that this might be different in the new build system.

Cheers,
Benno

> On Wed, Jul 23, 2025 at 11:39 AM Tamir Duberstein <tamird@...nel.org> wrote:
>>
>> Minor fixes in this series. The main one is fixing navigation in
>> pin_init_internal.
>>
>> This is my first series using tamird@...nel.org; please excude any
>> hiccups.
>>
>> Signed-off-by: Tamir Duberstein <tamird@...nel.org>
>> ---
>> Tamir Duberstein (3):
>>       scripts: generate_rust_analyzer: Add compiler_builtins -> core dep
>>       scripts: generate_rust_analyzer: Add pin_init -> compiler_builtins dep
>>       scripts: generate_rust_analyzer: Add pin_init_internal deps
>>
>>  scripts/generate_rust_analyzer.py | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> ---
>> base-commit: dff64b072708ffef23c117fa1ee1ea59eb417807
>> change-id: 20250723-rust-analyzer-pin-init-925467269001
>>
>> Best regards,
>> --
>> Tamir Duberstein <tamird@...nel.org>
>>