linux-kernel - Re: [PATCH 3/7] mtd: rawnand: ingenic: Simplify with scoped for each OF child loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f4f0697622ee26db9c3e09b1a8b64157666eb0b.camel@crapouillou.net>
Date: Fri, 02 Jan 2026 23:22:12 +0100
From: Paul Cercueil <paul@...pouillou.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>, Brian Norris
	 <computersforpeace@...il.com>, Kamal Dasu <kamal.dasu@...adcom.com>, 
 Broadcom internal kernel review list	
 <bcm-kernel-feedback-list@...adcom.com>, Miquel Raynal	
 <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, Vignesh
 Raghavendra <vigneshr@...com>, Harvey Hunt <harveyhuntnexus@...il.com>,
 Manivannan Sadhasivam	 <mani@...nel.org>, Stefan Agner <stefan@...er.ch>,
 Tudor Ambarus	 <tudor.ambarus@...aro.org>, Pratyush Yadav
 <pratyush@...nel.org>, Michael Walle	 <mwalle@...nel.org>, Nathan
 Chancellor <nathan@...nel.org>, Nick Desaulniers	
 <nick.desaulniers+lkml@...il.com>, Bill Wendling <morbo@...gle.com>, Justin
 Stitt <justinstitt@...gle.com>, linux-mtd@...ts.infradead.org,
 linux-kernel@...r.kernel.org, 	linux-mips@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH 3/7] mtd: rawnand: ingenic: Simplify with scoped for
 each OF child loop

Hi Krzysztof,

Le vendredi 02 janvier 2026 à 13:49 +0100, Krzysztof Kozlowski a
écrit :
> Use scoped for-each loop when iterating over device nodes to make
> code a
> bit simpler.
> 
> Signed-off-by: Krzysztof Kozlowski
> <krzysztof.kozlowski@....qualcomm.com>

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> index 47dc3efcee92..f1e2c82936b3 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> @@ -438,7 +438,6 @@ static int ingenic_nand_init_chips(struct
> ingenic_nfc *nfc,
>  				   struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> -	struct device_node *np;
>  	int i = 0;
>  	int ret;
>  	int num_chips = of_get_child_count(dev->of_node);
> @@ -449,11 +448,10 @@ static int ingenic_nand_init_chips(struct
> ingenic_nfc *nfc,
>  		return -EINVAL;
>  	}
>  
> -	for_each_child_of_node(dev->of_node, np) {
> +	for_each_child_of_node_scoped(dev->of_node, np) {
>  		ret = ingenic_nand_init_chip(pdev, nfc, np, i);
>  		if (ret) {
>  			ingenic_nand_cleanup_chips(nfc);
> -			of_node_put(np);
>  			return ret;
>  		}
>