linux-kernel - Re: [PATCH 0/3] scripts: generate_rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFEV6M7ZUBED.D22RP35TL64G@kernel.org>
Date: Sat, 03 Jan 2026 10:58:58 +0100
From: "Benno Lossin" <lossin@...nel.org>
To: "Tamir Duberstein" <tamird@...nel.org>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] scripts: generate_rust_analyzer: match
 rust/Makefile

On Fri Jan 2, 2026 at 9:34 PM CET, Tamir Duberstein wrote:
> On Fri, Jan 2, 2026 at 3:05 PM Benno Lossin <lossin@...nel.org> wrote:
>>
>> On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
>> > @Benno would you mind having a look at this series?
>>
>> Oh wow this is an old series! Sorry for missing it.
>>
>> I'm not maintaining the build system for pin-init, but from my side the
>> changes look okay. The commit messages are missing some context though:
>> why do we need these dependency edges? etc. If you fix that you can add
>>
>> Acked-by: Benno Lossin <lossin@...nel.org>
>>
>> Also note that this might be different in the new build system.
>
> Thanks for the review! I think the commits all include answers to
> "why": the first two make RA match the actual build and the final one
> does the same and also fixes navigation in pin_init_internal; before
> this series, go-to-symbol from pin_init_internal to e.g.
> proc_macro::TokenStream doesn't work.

Ah I missed the explanation since its so few words.

Cheers,
Benno