linux-kernel - Re: [PATCH] mm/zswap: fix error pointer free in zswap_cpu_comp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKEwX=PVZJZHJ9JyubqH4C63RLRiHvMaVYGc-TtY2jt9vGWzbQ@mail.gmail.com>
Date: Sun, 4 Jan 2026 00:41:15 -0800
From: Nhat Pham <nphamcs@...il.com>
To: Pavel Butsykin <pbutsykin@...udlinux.com>
Cc: hannes@...xchg.org, yosry.ahmed@...ux.dev, chengming.zhou@...ux.dev, 
	akpm@...ux-foundation.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH] mm/zswap: fix error pointer free in zswap_cpu_comp_prepare()

On Tue, Dec 30, 2025 at 11:46 PM Pavel Butsykin
<pbutsykin@...udlinux.com> wrote:
>
> crypto_alloc_acomp_node() may return ERR_PTR(), but the fail path checks
> only for NULL and can pass an error pointer to crypto_free_acomp().
> Use IS_ERR_OR_NULL() to only free valid acomp instances.
>
> Fixes: 779b9955f643 ("mm: zswap: move allocations during CPU init outside the lock")
> Cc: stable@...r.kernel.org
> Signed-off-by: Pavel Butsykin <pbutsykin@...udlinux.com>

Acked-by: Nhat Pham <nphamcs@...il.com>