linux-kernel - Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio dtsi for rk3506

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jL=Dv9Ad3EN_+WsD=tKVZORTbW5xcPaJUx3Zi7DNyvzruA@mail.gmail.com>
Date: Sun, 4 Jan 2026 13:07:02 +0100
From: Linus Walleij <linusw@...nel.org>
To: Ye Zhang <ye.zhang@...k-chips.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Heiko Stuebner <heiko@...ech.de>, Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	tao.huang@...k-chips.com
Subject: Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio
 dtsi for rk3506

On Wed, Dec 31, 2025 at 9:18 AM Ye Zhang <ye.zhang@...k-chips.com> wrote:

> This file is auto-generated to provide a complete set of RMIO
> configurations.   Our intention is to offer a generic library for all
> future board developers, so they can simply pick the needed nodes by
> phandle without manually looking up register values in the datasheet
> every time.   This improves usability and standardization.

That makes it even more important to use the standard pinmux = <>;
property in pinmux-node.yaml for this instead of custom properties.

If you establish a standard, then use a standard.

We have two ways of doing pin control in DT:

1. Use strings for groups and functions.

    function = "uart";
    groups = "uart-tx-rx", "uart-cts-rts";

Since a lot of people really, really like to shoehorn a lot of information
into the device tree instead,

2. Use pinmux = <....>;

This is an opaque property that contains magic numbers. By using the
pinmux properties, developers and maintainers know that this is some
magic numbers that sets up the mux.

No custom invented properties please.

Historically old properties like rockchip,pins exist for the same purpose
of pinmux = <>; but this needs to stop and migrate to the standard
bindings, not proliferate.

Yours,
Linus Walleij