linux-kernel - Re: [PATCH] drivers: pwm: replace `kernel::c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mrpcLaeiGjBcXNqTUwo00Y2MhhHWnWauou6exU1y920Q@mail.gmail.com>
Date: Sat, 3 Jan 2026 21:30:31 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Drew Fustini <fustini@...nel.org>, Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>
Cc: linux-riscv@...ts.infradead.org, linux-pwm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] drivers: pwm: replace `kernel::c_str!` with C-Strings

On Mon, Dec 22, 2025 at 7:24 AM Tamir Duberstein <tamird@...nel.org> wrote:
>
> From: Tamir Duberstein <tamird@...il.com>
>
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
>  drivers/pwm/pwm_th1520.rs | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs
> index e3b7e77356fc..8ae8f852ec02 100644
> --- a/drivers/pwm/pwm_th1520.rs
> +++ b/drivers/pwm/pwm_th1520.rs
> @@ -22,7 +22,6 @@
>
>  use core::ops::Deref;
>  use kernel::{
> -    c_str,
>      clk::Clk,
>      device::{Bound, Core, Device},
>      devres,
> @@ -327,7 +326,7 @@ fn drop(self: Pin<&mut Self>) {
>      OF_TABLE,
>      MODULE_OF_TABLE,
>      <Th1520PwmPlatformDriver as platform::Driver>::IdInfo,
> -    [(of::DeviceId::new(c_str!("thead,th1520-pwm")), ())]
> +    [(of::DeviceId::new(c"thead,th1520-pwm"), ())]
>  );
>
>  impl platform::Driver for Th1520PwmPlatformDriver {
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-pwm-c9b9a4701157
>
> Best regards,
> --
> Tamir Duberstein <tamird@...il.com>
>

@Uwe could you please have a look?

Cheers.
Tamir