linux-kernel - Re: [PATCH] rust: cpufreq: replace `kernel::c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mgxBhiOo=zoV3+gQeqndiJ1giQNp+a6vzCGHJRncEAHA@mail.gmail.com>
Date: Sat, 3 Jan 2026 21:31:35 -0500
From: Tamir Duberstein <tamird@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] rust: cpufreq: replace `kernel::c_str!` with C-Strings

On Mon, Dec 22, 2025 at 7:29 AM Tamir Duberstein <tamird@...nel.org> wrote:
>
> From: Tamir Duberstein <tamird@...il.com>
>
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Reviewed-by: Benno Lossin <lossin@...nel.org>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
>  drivers/cpufreq/rcpufreq_dt.rs | 5 ++---
>  rust/kernel/cpufreq.rs         | 3 +--
>  2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cpufreq/rcpufreq_dt.rs b/drivers/cpufreq/rcpufreq_dt.rs
> index 31e07f0279db..f17bf64c22e2 100644
> --- a/drivers/cpufreq/rcpufreq_dt.rs
> +++ b/drivers/cpufreq/rcpufreq_dt.rs
> @@ -3,7 +3,6 @@
>  //! Rust based implementation of the cpufreq-dt driver.
>
>  use kernel::{
> -    c_str,
>      clk::Clk,
>      cpu, cpufreq,
>      cpumask::CpumaskVar,
> @@ -52,7 +51,7 @@ impl opp::ConfigOps for CPUFreqDTDriver {}
>
>  #[vtable]
>  impl cpufreq::Driver for CPUFreqDTDriver {
> -    const NAME: &'static CStr = c_str!("cpufreq-dt");
> +    const NAME: &'static CStr = c"cpufreq-dt";
>      const FLAGS: u16 = cpufreq::flags::NEED_INITIAL_FREQ_CHECK | cpufreq::flags::IS_COOLING_DEV;
>      const BOOST_ENABLED: bool = true;
>
> @@ -197,7 +196,7 @@ fn register_em(policy: &mut cpufreq::Policy) {
>      OF_TABLE,
>      MODULE_OF_TABLE,
>      <CPUFreqDTDriver as platform::Driver>::IdInfo,
> -    [(of::DeviceId::new(c_str!("operating-points-v2")), ())]
> +    [(of::DeviceId::new(c"operating-points-v2"), ())]
>  );
>
>  impl platform::Driver for CPUFreqDTDriver {
> diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs
> index f968fbd22890..8be634eaabe9 100644
> --- a/rust/kernel/cpufreq.rs
> +++ b/rust/kernel/cpufreq.rs
> @@ -840,7 +840,6 @@ fn register_em(_policy: &mut Policy) {
>  /// ```
>  /// use kernel::{
>  ///     cpufreq,
> -///     c_str,
>  ///     device::{Core, Device},
>  ///     macros::vtable,
>  ///     of, platform,
> @@ -853,7 +852,7 @@ fn register_em(_policy: &mut Policy) {
>  ///
>  /// #[vtable]
>  /// impl cpufreq::Driver for SampleDriver {
> -///     const NAME: &'static CStr = c_str!("cpufreq-sample");
> +///     const NAME: &'static CStr = c"cpufreq-sample";
>  ///     const FLAGS: u16 = cpufreq::flags::NEED_INITIAL_FREQ_CHECK | cpufreq::flags::IS_COOLING_DEV;
>  ///     const BOOST_ENABLED: bool = true;
>  ///
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-cpufreq-725cd36ca0f1
>
> Best regards,
> --
> Tamir Duberstein <tamird@...il.com>
>

@Rafael could you please have a look?

Cheers.
Tamir