linux-kernel - Re: [PATCH 5/6] i2c: mv64xxx: use i2c_adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pl7oqiai.fsf@BLaptop.bootlin.com>
Date: Mon, 05 Jan 2026 14:51:33 +0100
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>, Wolfram Sang
 <wsa+renesas@...g-engineering.com>, Jean Delvare <jdelvare@...e.com>, Andi
 Shyti <andi.shyti@...nel.org>, Shyam Sundar S K
 <shyam-sundar.s-k@....com>, Nirujogi Pratap <pratap.nirujogi@....com>, Bin
 Du <bin.du@....com>, Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jan Dabros
 <jsd@...ihalf.com>, Hans Hu <hanshu@...oxin.com>
Cc: Bartosz Golaszewski <brgl@...nel.org>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org, Bartosz Golaszewski
 <bartosz.golaszewski@....qualcomm.com>
Subject: Re: [PATCH 5/6] i2c: mv64xxx: use i2c_adapter_dev()

Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com> writes:

> Use i2c_adapter_dev() where applicable in order to avoid direct
> dereferencing of struct device embedded within struct i2c_adapter.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>

Reviewed-by: Gregory CLEMENT <gregory.clement@...tlin.com>

Thanks,

Gregory
> ---
>  drivers/i2c/busses/i2c-mv64xxx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 1acba628e16c3bd1dbf82c777162870cbe3815ef..7892793d2a1cabf3376efcec1d031c3d764f7731 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -747,7 +747,7 @@ mv64xxx_i2c_xfer_core(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>  	struct mv64xxx_i2c_data *drv_data = i2c_get_adapdata(adap);
>  	int rc, ret = num;
>  
> -	rc = pm_runtime_resume_and_get(&adap->dev);
> +	rc = pm_runtime_resume_and_get(i2c_adapter_dev(adap));
>  	if (rc)
>  		return rc;
>  
> @@ -766,7 +766,7 @@ mv64xxx_i2c_xfer_core(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>  	drv_data->num_msgs = 0;
>  	drv_data->msgs = NULL;
>  
> -	pm_runtime_put_autosuspend(&adap->dev);
> +	pm_runtime_put_autosuspend(i2c_adapter_dev(adap));
>  
>  	return ret;
>  }
>
> -- 
> 2.47.3
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com