linux-kernel - Re: [PATCH 4/6] i2c: designware-amdisp: use i2c_adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1622683f-6afa-4743-8a93-ba49b38c6f95@amd.com>
Date: Mon, 5 Jan 2026 14:26:06 -0500
From: "Nirujogi, Pratap" <pnirujog@....com>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Jean Delvare <jdelvare@...e.com>, Andi Shyti <andi.shyti@...nel.org>,
 Shyam Sundar S K <shyam-sundar.s-k@....com>,
 Nirujogi Pratap <pratap.nirujogi@....com>, Bin Du <bin.du@....com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Gregory CLEMENT
 <gregory.clement@...tlin.com>, Hans Hu <hanshu@...oxin.com>
Cc: Bartosz Golaszewski <brgl@...nel.org>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] i2c: designware-amdisp: use i2c_adapter_dev()


On 12/23/2025 5:08 AM, Bartosz Golaszewski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Use i2c_adapter_dev() where applicable in order to avoid direct
> dereferencing of struct device embedded within struct i2c_adapter.
>
> Signed-off-by: Bartosz Golaszewski<bartosz.golaszewski@....qualcomm.com>

Acked-by: Pratap Nirujogi<pratap.nirujogi@....com>

(I'm assuming Andy's suggestion to use i2c_adapter_set_node() will be covered in the other patch series)

Thanks,
Pratap

> ---
>   drivers/i2c/busses/i2c-designware-amdisp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-amdisp.c b/drivers/i2c/busses/i2c-designware-amdisp.c
> index 450793d5f83921ac9a8c6d00414890779da49c07..67772bccb71927e870c11fa88340caabcb07f264 100644
> --- a/drivers/i2c/busses/i2c-designware-amdisp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdisp.c
> @@ -64,7 +64,7 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev)
>          adap = &isp_i2c_dev->adapter;
>          adap->owner = THIS_MODULE;
>          scnprintf(adap->name, sizeof(adap->name), AMDISP_I2C_ADAP_NAME);
> -       ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
> +       ACPI_COMPANION_SET(i2c_adapter_dev(adap), ACPI_COMPANION(&pdev->dev));
>          adap->dev.of_node = pdev->dev.of_node;
>          /* use dynamically allocated adapter id */
>          adap->nr = -1;
>
> --
> 2.47.3
>