linux-kernel - Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV0nA521iLnxYTVu@lizhi-Precision-Tower-5810>
Date: Tue, 6 Jan 2026 10:15:15 -0500
From: Frank Li <Frank.li@....com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Woojung Huh <woojung.huh@...rochip.com>,
	"maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" <UNGLinuxDriver@...rochip.com>,
	Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Marek Vasut <marex@...x.de>,
	"open list:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" <netdev@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev,
	shawnguo@...nel.org
Subject: Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl
 'reset' optional

On Tue, Jan 06, 2026 at 04:02:45PM +0100, Marco Felsch wrote:
> Hi Frank,
>
> thanks for fixing this.
>
> On 26-01-06, Frank Li wrote:
> > Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
> > description to set SPI mode") required both 'default' and 'reset' pinctrl
> > states for all compatible devices. However, this requirement should be only
> > applicable to KSZ8463.
> >
> > Make the 'reset' pinctrl state optional for all other Microchip DSA
> > devices while keeping it mandatory for KSZ8463.
> >
> > Fix below CHECK_DTBS warnings:
> >   arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> > 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#
> >
>
> Fixes tag?

This one is only fix warning, some maintainer wants add fixes tags only for
user visualable issue.

If maintainer want, it can be added when apply, commit hash already in
commit message.

>
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > index a8c8009414ae0..8d4a3a9a33fcc 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > @@ -40,6 +40,7 @@ properties:
> >        - const: reset
> >          description:
> >            Used during reset for strap configuration.
> > +    minItems: 1
>
> Does this mean that all others can now either specify 'reset' or
> 'default'? If yes, this seems wrong.

No,  It allow that
	 case 1: "default"
	 case 2: "default", "reset".

Don't allow 'reset' only.

Frank

>
> Regards,
>   Marco
>
> >
> >    reset-gpios:
> >      description:
> > @@ -153,6 +154,8 @@ allOf:
> >              const: microchip,ksz8463
> >      then:
> >        properties:
> > +        pinctrl-names:
> > +          minItems: 2
> >          straps-rxd-gpios:
> >            description:
> >              RXD0 and RXD1 pins, used to select SPI as bus interface.
> > --
> > 2.34.1
> >
> >
>
> --
> #gernperDu
> #CallMeByMyFirstName
>
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |