Message-ID: <zUWWtNtMhwr9_g1C6mdaGPvyls1-H_tCHfdMuWC35MYUzv88iiaEzS9RTUiucp4QU_RhvuTGiNcl_GV684b6h4-DmdnKPeCLGKB1RHEG6G8=@proton.me>
Date: Tue, 06 Jan 2026 20:28:03 +0000
From: kylebonnici <kylebonnici@...ton.me>
To: Michal Simek <michal.simek@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>, Peter Korsgaard <peter@...sgaard.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Kyle Bonnici <kylebonnici@...mail.com>
Subject: Re: [PATCH] Coding Style: Format arch/arm/boot/dts/xilinx

Hi,

Thanks for the feedback.

with regard to subject I am not sure in what subsystem file formatting would go (especially if we run it on even more files and more systems are modified) Your guidance would be appreciated.

With regard to improving the line wrapping, can you share some examples so that I can start looking on improving this?

To run on more files I will wait for feedback from Rob, Krzysztof and Conor.

Regards,
Kyle


Sent with Proton Mail secure email.

On Tuesday, January 6th, 2026 at 12:54 PM, Michal Simek <michal.simek@....com> wrote:

>
>
> Hi,
>
> On 12/18/25 13:51, kylebonnici wrote:
>
> > From: Kyle Bonnici kylebonnici@...mail.com
> >
> > - Convert hex value to lowercase
> > - align property values to ' = '
> > - clean up whitespaces
> > - fix indentation
> > - add new line between nodes
> >
> > The changes are generated using the dts-linter.
> >
> > This is just a sample of what the above tool can fix and this change is
> > intended to start the conversation on how I should suggest fixes to this repo
> > Without sending one big PR.
> >
> > Also, this is my first attempt at such a submission. Hopefully I did not miss
> > Anything fundamental in the submission process.
>
>
> my issue is with subject. Where Coding Style: subsystem is not defined.
>
> I tried your tool locally and I think handling in connection to long line should
> be improved.
>
> But in general I don't have a problem to use any tool to do coding style
> formatting.
>
> Newlines I don't really mind but lower case, additional spaces, tabs/spaces are
> nicely visible.
>
> I think you should get ack from Rob, Krzysztof and Conor to run it in bigger scale.
>
> Thanks,
> Michal
>
> > Signed-off-by: Kyle Bonnici kylebonnici@...ton.me
> > ---
> > arch/arm/boot/dts/xilinx/zynq-7000.dtsi | 72 +++++++++++--------
> > arch/arm/boot/dts/xilinx/zynq-cc108.dts | 11 ++-
> > arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 1 +
> > arch/arm/boot/dts/xilinx/zynq-parallella.dts | 7 +-
> > arch/arm/boot/dts/xilinx/zynq-zc702.dts | 17 +++++
> > arch/arm/boot/dts/xilinx/zynq-zc706.dts | 13 ++++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts | 10 +++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts | 5 ++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts | 6 ++
> > arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts | 8 +++
> > arch/arm/boot/dts/xilinx/zynq-zed.dts | 7 ++
> > .../boot/dts/xilinx/zynq-zturn-common.dtsi | 5 +-
> > 12 files changed, 126 insertions(+), 36 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> > index 153b8d93cbee..dd8a6528e8a7 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> > +++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> > @@ -27,10 +27,9 @@ cpu0: cpu@0 {
> > clock-latency = <1000>;
> > cpu0-supply = <&regulator_vccpint>;
> > operating-points = <
> > - /* kHz uV /
> > - 666667 1000000
> > - 333334 1000000
> > - >;
> > + / kHz uV */
> > + 666667 1000000
> > + 333334 1000000>;
> > };
> >
> > cpu1: cpu@1 {
> > @@ -78,17 +77,21 @@ out-ports {
> > /* replicator output ports /
> > port@0 {
> > reg = <0>;
> > +
> > replicator_out_port0: endpoint {
> > remote-endpoint = <&tpiu_in_port>;
> > };
> > };
> > +
> > port@1 {
> > reg = <1>;
> > +
> > replicator_out_port1: endpoint {
> > remote-endpoint = <&etb_in_port>;
> > };
> > };
> > };
> > +
> > in-ports {
> > / replicator input port */
> > port {
> > @@ -179,13 +182,13 @@ intc: interrupt-controller@...01000 {
> > compatible = "arm,cortex-a9-gic";
> > #interrupt-cells = <3>;
> > interrupt-controller;
> > - reg = <0xF8F01000 0x1000>,
> > - <0xF8F00100 0x100>;
> > + reg = <0xf8f01000 0x1000>,
> > + <0xf8f00100 0x100>;
> > };
> >
> > L2: cache-controller@...02000 {
> > compatible = "arm,pl310-cache";
> > - reg = <0xF8F02000 0x1000>;
> > + reg = <0xf8f02000 0x1000>;
> > interrupts = <0 2 4>;
> > arm,data-latency = <3 2 2>;
> > arm,tag-latency = <2 2 2>;
> > @@ -204,6 +207,7 @@ ocm: sram@...c0000 {
> > #address-cells = <1>;
> > #size-cells = <1>;
> > ranges = <0 0xfffc0000 0x10000>;
> > +
> > ocm-sram@0 {
> > reg = <0x0 0x10000>;
> > };
> > @@ -214,7 +218,7 @@ uart0: serial@...00000 {
> > status = "disabled";
> > clocks = <&clkc 23>, <&clkc 40>;
> > clock-names = "uart_clk", "pclk";
> > - reg = <0xE0000000 0x1000>;
> > + reg = <0xe0000000 0x1000>;
> > interrupts = <0 27 4>;
> > };
> >
> > @@ -223,7 +227,7 @@ uart1: serial@...01000 {
> > status = "disabled";
> > clocks = <&clkc 24>, <&clkc 41>;
> > clock-names = "uart_clk", "pclk";
> > - reg = <0xE0001000 0x1000>;
> > + reg = <0xe0001000 0x1000>;
> > interrupts = <0 50 4>;
> > };
> >
> > @@ -304,6 +308,7 @@ nfc0: nand-controller@0,0 {
> > reg = <0 0 0x1000000>;
> > status = "disabled";
> > };
> > +
> > nor0: flash@1,0 {
> > status = "disabled";
> > compatible = "cfi-flash";
> > @@ -336,24 +341,26 @@ slcr: slcr@...00000 {
> > #address-cells = <1>;
> > #size-cells = <1>;
> > compatible = "xlnx,zynq-slcr", "syscon", "simple-mfd";
> > - reg = <0xF8000000 0x1000>;
> > + reg = <0xf8000000 0x1000>;
> > ranges;
> > +
> > clkc: clkc@100 {
> > bootph-all;
> > #clock-cells = <1>;
> > compatible = "xlnx,ps7-clkc";
> > fclk-enable = <0>;
> > clock-output-names = "armpll", "ddrpll", "iopll", "cpu_6or4x",
> > - "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x", "ddr3x",
> > - "dci", "lqspi", "smc", "pcap", "gem0", "gem1",
> > - "fclk0", "fclk1", "fclk2", "fclk3", "can0", "can1",
> > - "sdio0", "sdio1", "uart0", "uart1", "spi0", "spi1",
> > - "dma", "usb0_aper", "usb1_aper", "gem0_aper",
> > - "gem1_aper", "sdio0_aper", "sdio1_aper",
> > - "spi0_aper", "spi1_aper", "can0_aper", "can1_aper",
> > - "i2c0_aper", "i2c1_aper", "uart0_aper", "uart1_aper",
> > - "gpio_aper", "lqspi_aper", "smc_aper", "swdt",
> > - "dbg_trc", "dbg_apb";
> > + "cpu_3or2x", "cpu_2x", "cpu_1x", "ddr2x",
> > + "ddr3x", "dci", "lqspi", "smc", "pcap", "gem0",
> > + "gem1", "fclk0", "fclk1", "fclk2", "fclk3",
> > + "can0", "can1", "sdio0", "sdio1", "uart0",
> > + "uart1", "spi0", "spi1", "dma", "usb0_aper",
> > + "usb1_aper", "gem0_aper", "gem1_aper",
> > + "sdio0_aper", "sdio1_aper", "spi0_aper",
> > + "spi1_aper", "can0_aper", "can1_aper",
> > + "i2c0_aper", "i2c1_aper", "uart0_aper",
> > + "uart1_aper", "gpio_aper", "lqspi_aper",
> > + "smc_aper", "swdt", "dbg_trc", "dbg_apb";
> > reg = <0x100 0x100>;
> > };
> >
> > @@ -380,10 +387,10 @@ dmac_s: dma-controller@...03000 {
> > * "dma4", "dma5", "dma6", "dma7";
> > */
> > interrupts = <0 13 4>,
> > - <0 14 4>, <0 15 4>,
> > - <0 16 4>, <0 17 4>,
> > - <0 40 4>, <0 41 4>,
> > - <0 42 4>, <0 43 4>;
> > + <0 14 4>, <0 15 4>,
> > + <0 16 4>, <0 17 4>,
> > + <0 40 4>, <0 41 4>,
> > + <0 42 4>, <0 43 4>;
> > #dma-cells = <1>;
> > clocks = <&clkc 27>;
> > clock-names = "apb_pclk";
> > @@ -412,7 +419,7 @@ ttc0: timer@...01000 {
> > interrupts = <0 10 4>, <0 11 4>, <0 12 4>;
> > compatible = "cdns,ttc";
> > clocks = <&clkc 6>;
> > - reg = <0xF8001000 0x1000>;
> > + reg = <0xf8001000 0x1000>;
> > };
> >
> > ttc1: timer@...02000 {
> > @@ -420,7 +427,7 @@ ttc1: timer@...02000 {
> > interrupts = <0 37 4>, <0 38 4>, <0 39 4>;
> > compatible = "cdns,ttc";
> > clocks = <&clkc 6>;
> > - reg = <0xF8002000 0x1000>;
> > + reg = <0xf8002000 0x1000>;
> > };
> >
> > scutimer: timer@...00600 {
> > @@ -466,6 +473,7 @@ etb@...01000 {
> > reg = <0xf8801000 0x1000>;
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > +
> > in-ports {
> > port {
> > etb_in_port: endpoint {
> > @@ -480,6 +488,7 @@ tpiu@...03000 {
> > reg = <0xf8803000 0x1000>;
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > +
> > in-ports {
> > port {
> > tpiu_in_port: endpoint {
> > @@ -499,8 +508,7 @@ funnel@...04000 {
> > out-ports {
> > port {
> > funnel_out_port: endpoint {
> > - remote-endpoint =
> > - <&replicator_in_port0>;
> > + remote-endpoint = <&replicator_in_port0>;
> > };
> > };
> > };
> > @@ -512,6 +520,7 @@ in-ports {
> > /* funnel input ports */
> > port@0 {
> > reg = <0>;
> > +
> > funnel0_in_port0: endpoint {
> > remote-endpoint = <&ptm0_out_port>;
> > };
> > @@ -519,6 +528,7 @@ funnel0_in_port0: endpoint {
> >
> > port@1 {
> > reg = <1>;
> > +
> > funnel0_in_port1: endpoint {
> > remote-endpoint = <&ptm1_out_port>;
> > };
> > @@ -526,8 +536,8 @@ funnel0_in_port1: endpoint {
> >
> > port@2 {
> > reg = <2>;
> > - funnel0_in_port2: endpoint {
> > - };
> > +
> > + funnel0_in_port2: endpoint {};
> > };
> > /* The other input ports are not connect to anything /
> > };
> > @@ -539,6 +549,7 @@ ptm@...9c000 {
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > cpu = <&cpu0>;
> > +
> > out-ports {
> > port {
> > ptm0_out_port: endpoint {
> > @@ -554,6 +565,7 @@ ptm@...9d000 {
> > clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > cpu = <&cpu1>;
> > +
> > out-ports {
> > port {
> > ptm1_out_port: endpoint {
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-cc108.dts b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> > index f5525c048426..25828ba9fa16 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-cc108.dts
> > @@ -55,6 +55,7 @@ ethernet_phy: ethernet-phy@1 {
> > &qspi {
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 { / 16 MB /
> > compatible = "jedec,spi-nor";
> > reg = <0x0>;
> > @@ -63,26 +64,32 @@ flash@0 { / 16 MB /
> > spi-rx-bus-width = <4>;
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot-bs";
> > reg = <0x0 0x400000>; / 4MB /
> > };
> > +
> > partition@...000 {
> > label = "qspi-linux";
> > reg = <0x400000 0x400000>; / 4MB /
> > };
> > +
> > partition@...000 {
> > label = "qspi-rootfs";
> > reg = <0x800000 0x400000>; / 4MB /
> > };
> > +
> > partition@...000 {
> > label = "qspi-devicetree";
> > reg = <0xc00000 0x100000>; / 1MB /
> > };
> > +
> > partition@...000 {
> > label = "qspi-scratch";
> > reg = <0xd00000 0x200000>; / 2MB /
> > };
> > +
> > partition@...000 {
> > label = "qspi-uboot-env";
> > reg = <0xf00000 0x100000>; / 1MB */
> > @@ -92,8 +99,8 @@ partition@...000 {
> >
> > &sdhci1 {
> > status = "okay";
> > - broken-cd ;
> > - wp-inverted ;
> > + broken-cd;
> > + wp-inverted;
> > };
> >
> > &uart0 {
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> > index 14f644156a6f..d4c07d28ec25 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> > @@ -53,6 +53,7 @@ &nfc0 {
> >
> > #address-cells = <1>;
> > #size-cells = <0>;
> > +
> > nand@0 {
> > reg = <0>;
> > };
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-parallella.dts b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> > index 366af4fcf8d9..e498feaa7ca4 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> > @@ -44,10 +44,10 @@ &gem0 {
> > ethernet_phy: ethernet-phy@0 {
> > /* Marvell 88E1318 */
> > compatible = "ethernet-phy-id0141.0e90",
> > - "ethernet-phy-ieee802.3-c22";
> > + "ethernet-phy-ieee802.3-c22";
> > reg = <0>;
> > marvell,reg-init = <0x3 0x10 0xff00 0x1e>,
> > - <0x3 0x11 0xfff0 0xa>;
> > + <0x3 0x11 0xfff0 0xa>;
> > };
> > };
> >
> > @@ -63,13 +63,16 @@ dcd1 {
> > regulator-name = "VDD_DSP";
> > regulator-always-on;
> > };
> > +
> > dcd2 {
> > regulator-name = "1P35V";
> > regulator-always-on;
> > };
> > +
> > ldo1 {
> > regulator-name = "VDD_ADJ";
> > };
> > +
> > ldo2 {
> > regulator-name = "VDD_GPIO";
> > regulator-always-on;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc702.dts b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> > index 6955637c5b1a..63eded827b37 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
> > @@ -34,6 +34,7 @@ chosen {
> > gpio-keys {
> > compatible = "gpio-keys";
> > autorepeat;
> > +
> > switch-14 {
> > label = "sw14";
> > gpios = <&gpio0 12 0>;
> > @@ -41,6 +42,7 @@ switch-14 {
> > wakeup-source;
> > autorepeat;
> > };
> > +
> > switch-13 {
> > label = "sw13";
> > gpios = <&gpio0 14 0>;
> > @@ -112,6 +114,7 @@ i2c@0 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <0>;
> > +
> > si570: clock-generator@5d {
> > #clock-cells = <0>;
> > compatible = "silabs,si570";
> > @@ -126,6 +129,7 @@ i2c@1 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <1>;
> > +
> > adv7511: hdmi-tx@39 {
> > compatible = "adi,adv7511";
> > reg = <0x39>;
> > @@ -141,6 +145,7 @@ i2c@2 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <2>;
> > +
> > eeprom: eeprom@54 {
> > compatible = "atmel,24c08";
> > reg = <0x54>;
> > @@ -151,6 +156,7 @@ i2c@3 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <3>;
> > +
> > gpio@21 {
> > compatible = "ti,tca6416";
> > reg = <0x21>;
> > @@ -163,6 +169,7 @@ i2c@4 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <4>;
> > +
> > rtc: rtc@51 {
> > compatible = "nxp,pcf8563";
> > reg = <0x51>;
> > @@ -173,14 +180,17 @@ i2c@7 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <7>;
> > +
> > hwmon@34 {
> > compatible = "ti,ucd9248";
> > reg = <0x34>;
> > };
> > +
> > hwmon@35 {
> > compatible = "ti,ucd9248";
> > reg = <0x35>;
> > };
> > +
> > hwmon@36 {
> > compatible = "ti,ucd9248";
> > reg = <0x36>;
> > @@ -396,32 +406,39 @@ &qspi {
> > bootph-all;
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0x0>;
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc706.dts b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> > index 3b803c698473..d6447e544d8f 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc706.dts
> > @@ -73,6 +73,7 @@ i2c@0 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <0>;
> > +
> > si570: clock-generator@5d {
> > #clock-cells = <0>;
> > compatible = "silabs,si570";
> > @@ -87,6 +88,7 @@ i2c@1 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <1>;
> > +
> > adv7511: hdmi-tx@39 {
> > compatible = "adi,adv7511";
> > reg = <0x39>;
> > @@ -102,6 +104,7 @@ i2c@2 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <2>;
> > +
> > eeprom: eeprom@54 {
> > compatible = "atmel,24c08";
> > reg = <0x54>;
> > @@ -112,6 +115,7 @@ i2c@3 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <3>;
> > +
> > gpio@21 {
> > compatible = "ti,tca6416";
> > reg = <0x21>;
> > @@ -124,6 +128,7 @@ i2c@4 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <4>;
> > +
> > rtc: rtc@51 {
> > compatible = "nxp,pcf8563";
> > reg = <0x51>;
> > @@ -134,6 +139,7 @@ i2c@7 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <7>;
> > +
> > ucd90120@65 {
> > compatible = "ti,ucd90120";
> > reg = <0x65>;
> > @@ -309,6 +315,7 @@ &qspi {
> > bootph-all;
> > status = "okay";
> > num-cs = <2>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0>, <1>;
> > @@ -316,26 +323,32 @@ flash@0 {
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> > index 5fe799c3c7cf..4929a5aa1678 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm010.dts
> > @@ -62,32 +62,39 @@ eeprom: eeprom@52 {
> > &qspi {
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0x0>;
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > @@ -104,14 +111,17 @@ &spi1 {
> > status = "okay";
> > num-cs = <4>;
> > is-decoded-cs = <0>;
> > +
> > flash@1 {
> > compatible = "sst25wf080", "jedec,spi-nor";
> > reg = <1>;
> > spi-max-frequency = <1000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "data";
> > reg = <0x0 0x100000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> > index f9a086fe66d3..d4e739772d7b 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm011.dts
> > @@ -51,20 +51,25 @@ &nfc0 {
> > status = "okay";
> > #address-cells = <1>;
> > #size-cells = <0>;
> > +
> > nand@0 {
> > reg = <0>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "nand-fsbl-uboot";
> > reg = <0x0 0x1000000>;
> > };
> > +
> > partition@...0000 {
> > label = "nand-linux";
> > reg = <0x1000000 0x2000000>;
> > };
> > +
> > partition@...0000 {
> > label = "nand-rootfs";
> > reg = <0x3000000 0x200000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> > index 24520e7d3965..32422aed77a3 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm012.dts
> > @@ -56,26 +56,32 @@ eeprom1: eeprom@52 {
> > &nor0 {
> > status = "okay";
> > bank-width = <1>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "nor-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@...000 {
> > label = "nor-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@...000 {
> > label = "nor-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@...000 {
> > label = "nor-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@...000 {
> > label = "nor-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> > index 103e87ea7253..9c94421bf650 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zc770-xm013.dts
> > @@ -61,6 +61,7 @@ si570: clock-generator@55 {
> > &qspi {
> > status = "okay";
> > num-cs = <2>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0>, <1>;
> > @@ -68,26 +69,32 @@ flash@0 {
> > spi-tx-bus-width = <1>;
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > @@ -100,6 +107,7 @@ &spi0 {
> > status = "okay";
> > num-cs = <4>;
> > is-decoded-cs = <0>;
> > +
> > eeprom: eeprom@2 {
> > compatible = "atmel,at25";
> > reg = <2>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zed.dts b/arch/arm/boot/dts/xilinx/zynq-zed.dts
> > index 52ba569b2b9f..dd46d71e3f36 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zed.dts
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zed.dts
> > @@ -51,6 +51,7 @@ &qspi {
> > bootph-all;
> > status = "okay";
> > num-cs = <1>;
> > +
> > flash@0 {
> > compatible = "jedec,spi-nor";
> > reg = <0>;
> > @@ -58,26 +59,32 @@ flash@0 {
> > spi-rx-bus-width = <4>;
> > spi-max-frequency = <50000000>;
> > m25p,fast-read;
> > +
> > partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > partition@0 {
> > label = "qspi-fsbl-uboot";
> > reg = <0x0 0x100000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-linux";
> > reg = <0x100000 0x500000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-device-tree";
> > reg = <0x600000 0x20000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-rootfs";
> > reg = <0x620000 0x5e0000>;
> > };
> > +
> > partition@...000 {
> > label = "qspi-bitstream";
> > reg = <0xc00000 0x400000>;
> > diff --git a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> > index defef9c8da13..57e6cda1a798 100644
> > --- a/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> > +++ b/arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi
> > @@ -33,6 +33,7 @@ chosen {
> >
> > gpio-leds {
> > compatible = "gpio-leds";
> > +
> > usr-led1 {
> > label = "usr-led1";
> > gpios = <&gpio0 0x0 0x1>;
> > @@ -49,6 +50,7 @@ usr-led2 {
> > gpio-keys {
> > compatible = "gpio-keys";
> > autorepeat;
> > +
> > key {
> > label = "K1";
> > gpios = <&gpio0 0x32 0x1>;
> > @@ -73,8 +75,7 @@ &gem0 {
> > phy-mode = "rgmii-id";
> > phy-handle = <&ethernet_phy>;
> >
> > - ethernet_phy: ethernet-phy@0 {
> > - };
> > + ethernet_phy: ethernet-phy@0 {};
> > };
> >
> > &sdhci0 {

Powered by blists - more mailing lists